Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds timer policy and trunk module #39206

Conversation

caphrim007
Copy link
Contributor

SUMMARY

Adds new modules for managing timer policy and trunks

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • bigip_timer_policy
  • bigip_trunk
ANSIBLE VERSION
ansible 2.6.0
  config file = None
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.6/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.6.4 (default, Mar 14 2018, 17:49:05) [GCC 4.9.2]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Apr 24, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/f5/bigip_trunk.py:278:43: E225 missing whitespace around operator

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/f5/bigip_trunk.py:0:0: E326 Value for "choices" from the argument_spec (['destination-mac', 'source-destination-ip', 'source-destination-mac']) for "frame_distribution_hash" does not match the documentation (['destination-mac', 'source-destination-ip-port', 'source-destination-mac'])

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Apr 24, 2018

@ansibot
Copy link
Contributor

ansibot commented Apr 24, 2018

@caphrim007 this PR contains more than one new module.

Please submit only one new module per pullrequest. For further explanation, please read grouped module documentation

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. f5 module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. python3 support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Apr 24, 2018
@caphrim007 caphrim007 force-pushed the feature.add-timer-policy-and-trunk-modules branch from 7d8c3ee to 0134bd7 Compare April 24, 2018 03:21
@caphrim007 caphrim007 removed the needs_triage Needs a first human triage before being processed. label Apr 24, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 24, 2018
@caphrim007 caphrim007 merged commit 3b11def into ansible:devel Apr 24, 2018
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 12, 2018
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@caphrim007 caphrim007 deleted the feature.add-timer-policy-and-trunk-modules branch August 28, 2018 17:12
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core_review In order to be merged, this PR must follow the core review workflow. f5 module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. python3 support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants