Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes coding conventions, adds a small feature #39211

Conversation

caphrim007
Copy link
Contributor

SUMMARY

Fixes some coding conventions and adds allowed_addresses to bigip_snmp_trap.

ISSUE TYPE
  • Feature Pull Request
  • Bugfix Pull Request
COMPONENT NAME

bigip modules

ANSIBLE VERSION
ansible 2.6.0
  config file = None
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.6/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.6.4 (default, Mar 14 2018, 17:49:05) [GCC 4.9.2]
ADDITIONAL INFORMATION

Fixes some coding conventions and adds allowed_addresses to bigip_snmp_trap.
@ansibot
Copy link
Contributor

ansibot commented Apr 24, 2018

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. f5 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category python3 support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Apr 24, 2018
@caphrim007 caphrim007 removed the needs_triage Needs a first human triage before being processed. label Apr 24, 2018
@caphrim007 caphrim007 merged commit 3227143 into ansible:devel Apr 24, 2018
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 12, 2018
Fixes some coding conventions and adds allowed_addresses to bigip_snmp_trap.
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
Fixes some coding conventions and adds allowed_addresses to bigip_snmp_trap.
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
Fixes some coding conventions and adds allowed_addresses to bigip_snmp_trap.
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
Fixes some coding conventions and adds allowed_addresses to bigip_snmp_trap.
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
Fixes some coding conventions and adds allowed_addresses to bigip_snmp_trap.
@caphrim007 caphrim007 deleted the bugfix.correct-coding-conventions-add-a-param-to-f5-modules branch August 28, 2018 17:12
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
Fixes some coding conventions and adds allowed_addresses to bigip_snmp_trap.
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core_review In order to be merged, this PR must follow the core review workflow. f5 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. networking Network category python3 support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants