fixes broken link in aci module docs #39247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acozine
added
networking
acozine
added this to Docsite work
in Ansible-maintained Collections Documentation
via automation
ansibot
added
aci
acozine
moved this from Docsite work
to In progress
in Ansible-maintained Collections Documentation
This was referenced Apr 26, 2018
Merged
|
Thanks to @jmcgill298 for the background
|
dagwieers
reviewed
Apr 27, 2018
| @@ -18,7 +18,7 @@ | |||
| - Bind Bridge Domain to L3 Out on Cisco ACI fabrics. | |||
| notes: | |||
| - The C(bd) and C(l3out) parameters should exist before using this module. | |||
| The M(aci_bd) and M(aci_l3out) can be used for these. | |||
| The M(aci_bd) and M(aci_l3out_route_tag_policy) can be used for these. | |||
There was a problem hiding this comment.
That is incorrect. It really should be aci_l3out, which does not exist as a module yet, but is in the pipeline.
Currently users build the l3out using aci_rest. We have a ticket open wrt. this, the documentation is based on the legacy modules which did include the aci_l3out module but was pretty limited in functionality. We are waiting for ACI experts to guide us in how they see this work in the future.
|
It's aci_l3out, but that's just a detail. (l2out exists too) |
|
OK, so will change to |
|
Thanks @gundalow, @dagwieers and @jmcgill298. I've made the correct fix. |
dagwieers
approved these changes
Apr 27, 2018
Ansible-maintained Collections Documentation
automation
moved this from In progress
to Done
Apr 27, 2018
acozine
pushed a commit
to acozine/ansible
that referenced
this pull request
Apr 27, 2018
* fixes broken link in aci module docs * makes correct fix for aci broken link (cherry picked from commit 4801bf9)
acozine
pushed a commit
that referenced
this pull request
Apr 30, 2018
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 12, 2018
* fixes broken link in aci module docs * makes correct fix for aci broken link
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
* fixes broken link in aci module docs * makes correct fix for aci broken link
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
* fixes broken link in aci module docs * makes correct fix for aci broken link
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
* fixes broken link in aci module docs * makes correct fix for aci broken link
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
* fixes broken link in aci module docs * makes correct fix for aci broken link
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
* fixes broken link in aci module docs * makes correct fix for aci broken link
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
As part of making all rST warnings fatal on Shippable, we are eliminating warnings from the docs build.
The documentation for the
aci_bd_to_l2outrefers to a non-existent module (aci_l2out), triggering aWARNING: undefined labelerror. I made an educated guess as to where that link should point. If this is not the correct target, please let me know.ISSUE TYPE
COMPONENT NAME
aci_bd_to_l2out module
ANSIBLE VERSION
2.5