Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds various features and fixes #39271

Merged

Conversation

caphrim007
Copy link
Contributor

SUMMARY
  • a refactor of pool member and node modules to be inline with current f5 conventions
  • Added priority_group_activation to pools
  • various other small convention fixes and bug fixes
ISSUE TYPE
  • Feature Pull Request
  • Bugfix Pull Request
COMPONENT NAME

bigip components

ANSIBLE VERSION
ansible 2.6.0
  config file = /here/test/integration/ansible.cfg
  configured module search path = ['/here/library/modules']
  ansible python module location = /usr/local/lib/python3.6/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.6.4 (default, Mar 14 2018, 17:49:05) [GCC 4.9.2]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Apr 25, 2018

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. f5 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category python3 support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Apr 25, 2018
@caphrim007 caphrim007 removed the needs_triage Needs a first human triage before being processed. label Apr 25, 2018
@ansibot
Copy link
Contributor

ansibot commented Apr 25, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/f5/bigip_pool_member.py:208:24: W291 trailing whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 15 errors:

lib/ansible/modules/network/f5/bigip_pool_member.py:0:0: E309 version_added for new option (fqdn) should be 2.6. Currently 2.5
lib/ansible/modules/network/f5/bigip_pool_member.py:0:0: E309 version_added for new option (name) should be 2.6. Currently 0.0
lib/ansible/modules/network/f5/bigip_pool_member.py:0:0: E319 RETURN.connection_limit.type: not a valid value for dictionary value @ data['type']. Got 'integer'
lib/ansible/modules/network/f5/bigip_pool_member.py:0:0: E319 RETURN.priority_group.type: not a valid value for dictionary value @ data['type']. Got 'integer'
lib/ansible/modules/network/f5/bigip_pool_member.py:0:0: E319 RETURN.rate_limit.type: not a valid value for dictionary value @ data['type']. Got 'integer'
lib/ansible/modules/network/f5/bigip_pool_member.py:0:0: E319 RETURN.ratio.type: not a valid value for dictionary value @ data['type']. Got 'integer'
lib/ansible/modules/network/f5/bigip_pool_member.py:0:0: E322 "monitor_state" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/network/f5/bigip_pool_member.py:0:0: E322 "reuse_nodes" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/network/f5/bigip_pool_member.py:0:0: E322 "session_state" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/network/f5/bigip_pool_member.py:0:0: E324 Value for "default" from the argument_spec (True) for "reuse_nodes" does not match the documentation (False)
lib/ansible/modules/network/f5/bigip_pool_member.py:0:0: E325 argument_spec for "fqdn_auto_populate" defines type="bool" but documentation does not
lib/ansible/modules/network/f5/bigip_pool_member.py:0:0: E325 argument_spec for "reuse_nodes" defines type="bool" but documentation does not
lib/ansible/modules/network/f5/bigip_pool_member.py:0:0: E326 Value for "choices" from the argument_spec (['enabled', 'disabled']) for "monitor_state" does not match the documentation ([])
lib/ansible/modules/network/f5/bigip_pool_member.py:0:0: E326 Value for "choices" from the argument_spec (['enabled', 'disabled']) for "session_state" does not match the documentation ([])
test/sanity/validate-modules/ignore.txt:1082:1: A102 Remove since "lib/ansible/modules/network/f5/bigip_pool.py" passes "E326" test

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 25, 2018
@caphrim007 caphrim007 force-pushed the various-features-and-fixes-f5-modules-03 branch from 61423a3 to a584eee Compare April 25, 2018 04:48
@ansibot
Copy link
Contributor

ansibot commented Apr 25, 2018

@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Apr 25, 2018
* a refactor of pool member and node modules to be inline with current f5 conventions
* Added priority_group_activation to pools
* various other small convention fixes and bug fixes
@ansibot
Copy link
Contributor

ansibot commented Apr 25, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/f5/bigip_pool_member.py:0:0: E309 version_added for new option (reuse_nodes) should be 2.6. Currently 0.0

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Apr 25, 2018
@caphrim007 caphrim007 force-pushed the various-features-and-fixes-f5-modules-03 branch from a584eee to 1917075 Compare April 25, 2018 05:10
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 25, 2018
@caphrim007 caphrim007 merged commit fb26428 into ansible:devel Apr 25, 2018
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 12, 2018
* a refactor of pool member and node modules to be inline with current f5 conventions
* Added priority_group_activation to pools
* various other small convention fixes and bug fixes
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
* a refactor of pool member and node modules to be inline with current f5 conventions
* Added priority_group_activation to pools
* various other small convention fixes and bug fixes
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
* a refactor of pool member and node modules to be inline with current f5 conventions
* Added priority_group_activation to pools
* various other small convention fixes and bug fixes
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
* a refactor of pool member and node modules to be inline with current f5 conventions
* Added priority_group_activation to pools
* various other small convention fixes and bug fixes
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
* a refactor of pool member and node modules to be inline with current f5 conventions
* Added priority_group_activation to pools
* various other small convention fixes and bug fixes
@caphrim007 caphrim007 deleted the various-features-and-fixes-f5-modules-03 branch August 28, 2018 17:12
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
* a refactor of pool member and node modules to be inline with current f5 conventions
* Added priority_group_activation to pools
* various other small convention fixes and bug fixes
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core_review In order to be merged, this PR must follow the core review workflow. f5 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. networking Network category python3 support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants