VMware: Refactor disc logic

[Akasurde]

SUMMARY

• Refactoring related to network device
• Assign unique random temporary key while creating SCSI or/and IDE controller devices
• Add testcase for this change

Fixes: #38679

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

lib/ansible/modules/cloud/vmware/vmware_guest.py
test/integration/targets/vmware_guest/tasks/cdrom_d1_c1_f0.yml

ANSIBLE VERSION

2.6devel

[ansibot]

cc @Akasurde @dav1x @nerzhul @pdellaert
click here for bot help

[gundalow]

Would it be worth calling the task again and checking .changed == false?

[Akasurde]

Yes. Thanks for suggestion. I will update it with same.

[Akasurde]

cc @dericcrago @pdellaert Could you please review this ?

[MikeKlebolt]

@Akasurde , I'm getting the following error when I use this patch:

  msg: 'Failed to create a virtual machine : The device ''5'' is referring to a nonexisting controller ''-,278''.'

fatal: [vm -> localhost]: FAILED! => changed=false
  invocation:
    module_args:
      annotation: null
      cdrom:
        type: client
      cluster: null
      customization: {}
      customvalues:
      - key: sched.cpu.latencySensitivity
        value: normal
      - key: sched.mem.prealloc
        value: 'True'
      - key: sched.swap.vmxSwapEnabled
        value: 'False'
      - key: isolation.tools.connectable.disable
        value: 'True'
      - key: tools.setInfo.sizeLimit
        value: '1048576'
      - key: isolation.tools.diskShrink.disable
        value: 'True'
      - key: isolation.tools.diskWiper.disable
        value: 'True'
      - key: isolation.tools.hgfs.disable
        value: 'True'
      - key: isolation.tools.copy.disable
        value: 'True'
      - key: isolation.tools.paste.disable
        value: 'True'
      - key: isolation.tools.setGUIOptions.enable
        value: 'False'
      - key: isolation.tools.setOption.disable
        value: 'True'
      - key: log.rotateSize
        value: '100000'
      - key: log.keepOld
        value: '6'
      - key: isolation.device.connectable.disable
        value: 'True'
      - key: isolation.device.edit.disable
        value: 'True'
      - key: isolation.tools.log.disable
        value: 'True'
      - key: isolation.tools.unity.push.update.disable
        value: 'True'
      - key: isolation.tools.ghi.launchmenu.change
        value: 'True'
      - key: isolation.tools.hgfsServerSet.disable
        value: 'True'
      - key: isolation.tools.memSchedFakeSampleStats.disable
        value: 'True'
      - key: isolation.tools.getCreds.disable
        value: 'True'
      datacenter: REDACTED
      disk:
      - datastore: local-datastore
        size_gb: 30
        type: thin
      esxi_hostname: REDACTED
      folder: /DCC/REDACTED/vm
      force: false
      guest_id: rhel6_64Guest
      hardware:
        hotadd_cpu: false
        hotremove_cpu: false
        memory_mb: '1024'
        num_cpus: '1'
        scsi: paravirtual
      hostname: REDACTED
      is_template: false
      linked_clone: false
      name: REDACTED
      name_match: first
      networks:
      - device_type: vmxnet3
        name: vlan1640_jumpkick
        type: dhcp
      - device_type: vmxnet3
        name: vlan603
        type: dhcp
      password: VALUE_SPECIFIED_IN_NO_LOG_PARAMETER
      port: 443
      resource_pool: null
      snapshot_src: null
      state: present
      state_change_timeout: 0
      template: null
      username: REDACTED
      uuid: null
      validate_certs: false
      vapp_properties: []
      wait_for_ip_address: false
  msg: 'Failed to create a virtual machine : The device ''5'' is referring to a nonexisting controller ''-,278''.'

[Akasurde]

@MikeKlebolt Thanks for testing this change. Do you face this error when you create a new VM or reconfigure existing one ?

[MikeKlebolt]

Sorry for not clarifying. This is when creating a new VM.

[ansibot]

cc @warthog9
click here for bot help

[bbeaudoin]

Ran into this issue with Ansible 2.5.2. Previously virtual hard disks were being improperly associated with the ide controller despite requesting a scsi controller and, when a virtual cdrom was present, the VM would fail to create when a second disk was requested.

With the updated vmware-guest.py in the PR, the virtual cdrom was associated with ide0:0 and virtual disks were assigned to scsi0:n as expected.

[toxicvengeance]

Can confirm what @bbeaudoin said. Virtual disks are now assigned to scsi0:n. Before they were incorrectly assigned to IDE which makes hotplugging impossible.

Would be nice if this PR gets accepted soon.

[Akasurde]

@toxicvengeance Thanks for the feedback.

[Akasurde]

@pdellaert @dericcrago Could you please review this ?

[Alex5252]

I checked the version cadbd6e#diff-ed147163551d1eaa084b21f6bab29f96
that gave an error:
"Failed to create a virtual machine : Number of virtual devices exceeds the maximum for a given controller."

With commit https://github.com/ansible/ansible/pull/39285/files in this thread performs a playbook with my section (creating two discs) without errors:

  disk:
  - size_gb: 8
    type: thin
    autoselect_datastore: no
    datastore: datastore1
  - size_gb: 123
    type: thin
    autoselect_datastore: no
    datastore: datastore1
  hardware:
    num_cpus: 2
    memory_mb: 8192
    scsi: lsilogic
  cdrom:
    type: iso
    iso_path: "[datastore1] isos/disk1.iso"
  networks:

All ok.

[njohnsonmortenson]

This has fixed my issue related to not being able to mount more than one hard drive during setup, with the same issue as Alex above. All OK after pushing this commit to our Ansible setup.

    vmware_guest:
      hostname: '{{ vsphere_host }}'
      validate_certs: no
      cluster: '[removed]'
      datacenter: '[removed]'
      folder: Test
      name: '{{ inventory_hostname }}'
      state: poweredon
      guest_id: windows8Server64Guest
      annotation: "{{ notes }} - {{ creationdate }}"
      disk:
      - size_gb: "{{vm_cdrive}}"
        type: thin
        datastore: '{{ vsphere_datastore }}'
      - size_gb: "{{vm_ddrive}}"
        type: thin
        datastore: '{{ vsphere_datastore }}'
      networks:
      - name: 'NPD_EntServer_916_10.9.16.0'
        device_type: vmxnet3
      hardware:
        memory_mb: '{{ vm_memory }}'
        num_cpus: '{{ vm_cpus }}'
      cdrom:
        type: iso
        iso_path: '[ntap_n2_ISO] LiteTouchMedia.iso'