Ensure timezone tests reset system timezone to UTC #39326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattclay
requested changes
Apr 25, 2018
| - block: | ||
| - name: set timezone to Etc/UTC | ||
| timezone: | ||
| name: Etc/UTC |
There was a problem hiding this comment.
Register the result of this change so the test knows what the original timezone was.
| always: | ||
| - name: Return timezone to UTC | ||
| timezone: | ||
| name: Etc/UTC |
There was a problem hiding this comment.
Restore the timezone to the original value registered at the start of the test.
ansibot
added
bug
samdoran
changed the title
samdoran
force-pushed
the
timezone-tests
branch
from
ec20ae4
to
d1c284a
Compare
mattclay
requested changes
Apr 25, 2018
| timezone: | ||
| name: Etc/UTC | ||
| - block: | ||
| - name: Set timezone to Etc/UTC |
There was a problem hiding this comment.
This task should be outside the block. That will avoid potential errors if the task were to fail and the always block tried to restore a previous timezone which hadn't yet been determined.
mattclay
approved these changes
Apr 25, 2018
ansibot
removed
the
needs_revision
mattclay
pushed a commit
that referenced
this pull request
May 9, 2018
(cherry picked from commit fda67ba)
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 12, 2018
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The
timezonetests changes the system timezone and does not set it back to UTC. Since the test instances are long-lived, this could cause problems for subsequent tests.This change puts the test inside a block to ensure the timezone is always reset even if the
timezonetest fails.ISSUE TYPE
COMPONENT NAME
/test/integration/targets/timezone/tasks/main.ymlANSIBLE VERSION