Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

call diff callback also when task diff is true #39366

Merged
merged 1 commit into from
Apr 26, 2018
Merged

call diff callback also when task diff is true #39366

merged 1 commit into from
Apr 26, 2018

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Apr 26, 2018

SUMMARY

fixes #31129

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

diff

ANSIBLE VERSION
2.4-.26

@bcoca bcoca added this to To Do in 2.5.x blocker list via automation Apr 26, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 26, 2018
@samdoran
Copy link
Contributor

Test failures are not related to this PR.

@samdoran samdoran merged commit d76298b into ansible:devel Apr 26, 2018
@ansibot
Copy link
Contributor

ansibot commented Apr 26, 2018

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

.github/BOTMETA.yml:437:3: key-duplicates duplication of key "$modules/net_tools/nios/" in mapping

click here for bot help

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Apr 26, 2018
samdoran pushed a commit to samdoran/ansible that referenced this pull request Apr 26, 2018
@bcoca @samdoran
call diff callback also when task diff is true (ansible#39366)
aa5edc0 
fixes ansible#31129

(cherry picked from commit d76298b)
@samdoran samdoran mentioned this pull request Apr 26, 2018
Merged
@bcoca bcoca deleted the display_task_diff branch April 26, 2018 18:54
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Apr 26, 2018
@bcoca bcoca moved this from To Do to Done in 2.5.x blocker list Apr 27, 2018
bcoca pushed a commit that referenced this pull request Apr 27, 2018
@samdoran @bcoca
Backport #39366 - call diff callback also when task diff is true (#39372
070c7b7 
)

* call diff callback also when task diff is true (#39366)

fixes #31129

(cherry picked from commit d76298b)

* Add changelog entry
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 12, 2018
@bcoca
call diff callback also when task diff is true (ansible#39366)
533d5b1 
fixes ansible#31129
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@bcoca
call diff callback also when task diff is true (ansible#39366)
13657bf 
fixes ansible#31129
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@bcoca
call diff callback also when task diff is true (ansible#39366)
685c24b 
fixes ansible#31129
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@bcoca
call diff callback also when task diff is true (ansible#39366)
642cb5c 
fixes ansible#31129
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@bcoca
call diff callback also when task diff is true (ansible#39366)
b29fb7e 
fixes ansible#31129
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@bcoca @ilicmilan
call diff callback also when task diff is true (ansible#39366)
a803c8a 
fixes ansible#31129
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
2.5.x blocker list
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

diff directive does not behave the same as '--diff' on the command line
3 participants
@bcoca @samdoran @ansibot