Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install git in pip tests #39460

Merged
merged 2 commits into from
May 2, 2018
Merged

Install git in pip tests #39460

merged 2 commits into from
May 2, 2018

Conversation

robinro
Copy link
Contributor

@robinro robinro commented Apr 28, 2018

SUMMARY

Install git in the pip tests. Fixes the tests, which currently fail on rhel/freebsd due to git missing.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

pip

ANSIBLE VERSION

devel

ADDITIONAL INFORMATION

@robinro
Copy link
Contributor Author

robinro commented Apr 28, 2018

Once this is merged, please rerun the tests of
#38788
#38789
#38790
and potentially merge them.

@ansibot
Copy link
Contributor

ansibot commented Apr 28, 2018

@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 28, 2018
@robinro
Copy link
Contributor Author

robinro commented Apr 28, 2018

This change is already part of #37973, so closing this.

@robinro robinro closed this Apr 28, 2018
@robinro robinro deleted the pip-tests-git branch April 28, 2018 15:35
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label May 1, 2018
@robinro robinro restored the pip-tests-git branch May 2, 2018 13:51
@robinro robinro reopened this May 2, 2018
@robinro
Copy link
Contributor Author

robinro commented May 2, 2018

#37973 Has other issues, so this should be merged first to get the pipeline of broken pip PRs going again.

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label May 2, 2018
@robinro
Copy link
Contributor Author

robinro commented May 2, 2018

This was caused by #35197.

@jctanner jctanner merged commit 90354d2 into ansible:devel May 2, 2018
@robinro robinro deleted the pip-tests-git branch May 2, 2018 14:28
mattclay pushed a commit to mattclay/ansible that referenced this pull request May 9, 2018
* Install git in pip tests

* Ignore MacOSX

(cherry picked from commit 90354d2)
mattclay pushed a commit that referenced this pull request May 9, 2018
* Install git in pip tests

* Ignore MacOSX

(cherry picked from commit 90354d2)
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 12, 2018
* Install git in pip tests

* Ignore MacOSX
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
* Install git in pip tests

* Ignore MacOSX
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
* Install git in pip tests

* Ignore MacOSX
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
* Install git in pip tests

* Ignore MacOSX
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
* Install git in pip tests

* Ignore MacOSX
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
* Install git in pip tests

* Ignore MacOSX
@ansible ansible locked and limited conversation to collaborators May 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants