Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fetching ios default running config #39475

Merged
merged 1 commit into from
May 2, 2018

Conversation

ganeshrn
Copy link
Member

@ganeshrn ganeshrn commented Apr 29, 2018

SUMMARY

Fixes #39342
If default option is enable in that case only
add 'all' or 'full' flag

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ios_config

ANSIBLE VERSION
2.5
ADDITIONAL INFORMATION

If default option is enable in that case only
add 'all' or 'full' flag
@ansibot
Copy link
Contributor

ansibot commented Apr 29, 2018

@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 29, 2018
@ganeshrn ganeshrn added this to Need CP into 2.5.3 in zzz NOT USED: Networking Bugs Apr 30, 2018
@ganeshrn ganeshrn removed the needs_triage Needs a first human triage before being processed. label Apr 30, 2018
@SteveRodrigue
Copy link

Same bug for me.... ios_config is ALWAYS fetching config using "show run all" even if explicitly set "defaults: no" in my playbook.

@ganeshrn ganeshrn merged commit eb5e15e into ansible:devel May 2, 2018
@ganeshrn ganeshrn deleted the ios_default_all branch May 2, 2018 13:58
ganeshrn added a commit to ganeshrn/ansible that referenced this pull request May 2, 2018
If default option is enable in that case only
add 'all' or 'full' flag
(cherry picked from commit eb5e15e)

Update changelog
ganeshrn added a commit that referenced this pull request May 2, 2018
If default option is enable in that case only
add 'all' or 'full' flag
(cherry picked from commit eb5e15e)

Update changelog
@ganeshrn
Copy link
Member Author

ganeshrn commented May 2, 2018

Cherry-pick to stable-2.5 #39608. Fix will be available in 2.5.3

@myownhost
Copy link

I tried the fix #39475 in my ansible. Works fine for me, but the problem after installing the patch is that the defaults: yes parameter also only execute the command show running-config and not show running-config all.

@ganeshrn
Copy link
Member Author

ganeshrn commented May 4, 2018

@myownhost Ah, the module side changes are missed. Please apply PR #39741 as well and retest.

@myownhost
Copy link

@ganeshrn test this morning was successfull with the patch #39741.
Many thanks.

@ganeshrn
Copy link
Member Author

ganeshrn commented May 8, 2018

@myownhost Thanks for the confirmation.

oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 12, 2018
If default option is enable in that case only
add 'all' or 'full' flag
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
If default option is enable in that case only
add 'all' or 'full' flag
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
If default option is enable in that case only
add 'all' or 'full' flag
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
If default option is enable in that case only
add 'all' or 'full' flag
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
If default option is enable in that case only
add 'all' or 'full' flag
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
If default option is enable in that case only
add 'all' or 'full' flag
@dagwieers dagwieers added ios Cisco IOS community cisco Cisco technologies labels Feb 27, 2019
@ansible ansible locked and limited conversation to collaborators May 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug. cisco Cisco technologies ios Cisco IOS community networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

failed with ios_config module that using wrong "show running-config all"
6 participants