Fix unset 'ansible_virtualization_role' fact #39514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error was:
AttributeError("'str' object has no attribute 'startwith'",)
Closes ansible#39138
ansibot
added
bug
Akasurde
removed
the
needs_triage
|
@pilou- Thanks for debugging this. |
|
shipit |
Akasurde
pushed a commit
to Akasurde/ansible
that referenced
this pull request
May 9, 2018
Error was:
AttributeError("'str' object has no attribute 'startwith'",)
Closes ansible#39138
(cherry picked from commit 2397ca1)
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 12, 2018
Error was:
AttributeError("'str' object has no attribute 'startwith'",)
Closes ansible#39138
Akasurde
added a commit
that referenced
this pull request
May 14, 2018
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
Error was:
AttributeError("'str' object has no attribute 'startwith'",)
Closes ansible#39138
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
Error was:
AttributeError("'str' object has no attribute 'startwith'",)
Closes ansible#39138
tonal
pushed a commit
to tonal/ansible
that referenced
this pull request
May 15, 2018
Error was:
AttributeError("'str' object has no attribute 'startwith'",)
Closes ansible#39138
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
Error was:
AttributeError("'str' object has no attribute 'startwith'",)
Closes ansible#39138
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
Error was:
AttributeError("'str' object has no attribute 'startwith'",)
Closes ansible#39138
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
Error was:
AttributeError("'str' object has no attribute 'startwith'",)
Closes ansible#39138
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Error was:
AttributeError("'str' object has no attribute 'startwith'",)resulting inansible_virtualization_rolebeing not set.Fixes #39138
ISSUE TYPE
COMPONENT NAME
lib/ansible/module_utils/facts/virtual/linux.py
ANSIBLE VERSION
ADDITIONAL INFORMATION
Present in 2.5.1 (ae0a9a5), should be backported in 2.5.2.
Bug wasn't caught by the CI because integration tests don't use
realhardware (moreover bug only occurs whenkvm/vboxdrvmodules aren't loaded).