Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EdgeOS module improvements #39530

Merged
merged 2 commits into from May 22, 2018
Merged

EdgeOS module improvements #39530

merged 2 commits into from May 22, 2018

Conversation

samdoran
Copy link
Contributor

SUMMARY
  • Update docs and use to_native on strings

Fixes #39499

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

edgeos_command.py
edgeos_config.py

ANSIBLE VERSION
2.6
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Apr 30, 2018

cc @beardymcbeards @Qalthos
click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 30, 2018
@ansibot
Copy link
Contributor

ansibot commented Apr 30, 2018

The test ansible-test sanity --test docs-build [explain] failed with 2 errors:

docs/docsite/rst/modules/edgeos_command_module.rst:24:0: warning: Unknown target name: "network guide < ../network/getting_started/network_differences.html#multiple-communication-protocols>".
docs/docsite/rst/modules/edgeos_config_module.rst:22:0: warning: Unknown target name: "network guide < ../network/getting_started/network_differences.html#multiple-communication-protocols>".

click here for bot help

@maxamillion maxamillion removed the needs_triage Needs a first human triage before being processed. label May 1, 2018
Qalthos
Qalthos suggested changes May 2, 2018
View reviewed changes
lib/ansible/modules/network/edgeos/edgeos_command.py Outdated
@@ -149,7 +153,7 @@ def main():
try:
conditionals = [Conditional(c) for c in wait_for]
except AttributeError as e:
module.fail_json(msg=str(e))
module.fail_json(msg=to_native(e))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you want to use to_text instead of to_native

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One day I won't get those mixed up.

@ansibot
Copy link
Contributor

ansibot commented May 2, 2018

The test ansible-test sanity --test docs-build [explain] failed with 2 errors:

docs/docsite/rst/modules/edgeos_command_module.rst:24:0: warning: Unknown target name: "network guide < ../network/getting_started/network_differences.html#multiple-communication-protocols>".
docs/docsite/rst/modules/edgeos_config_module.rst:22:0: warning: Unknown target name: "network guide < ../network/getting_started/network_differences.html#multiple-communication-protocols>".

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented May 2, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/plugins/action/edgeos_config.py:43:8: unreachable Unreachable code

The test ansible-test sanity --test docs-build [explain] failed with 2 errors:

docs/docsite/rst/modules/edgeos_command_module.rst:24:0: warning: Unknown target name: "network guide < ../network/getting_started/index.html>".
docs/docsite/rst/modules/edgeos_config_module.rst:22:0: warning: Unknown target name: "network guide < ../network/getting_started/index.html>".

click here for bot help

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 10, 2018
@samdoran samdoran changed the title [WIP] EdgeOS module improvements EdgeOS module improvements May 17, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels May 17, 2018
@ansibot
Copy link
Contributor

ansibot commented May 17, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/plugins/action/edgeos_config.py:43:8: unreachable Unreachable code

The test ansible-test sanity --test docs-build [explain] failed with 1 error:

docs/docsite/rst/modules/edgeos_config_module.rst:22:0: warning: Unknown target name: "network guide < ../network/getting_started/index.html>".

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. affects_2.6 This issue/PR affects Ansible v2.6 and removed core_review In order to be merged, this PR must follow the core review workflow. labels May 17, 2018
@samdoran samdoran merged commit d5dbd8c into ansible:devel May 22, 2018
@samdoran samdoran deleted the edgeos-docs branch May 22, 2018 16:22
samdoran added a commit to samdoran/ansible that referenced this pull request May 22, 2018
@samdoran
EdgeOS module improvements (ansible#39530)
2b8d845 
* Update docs and use to_text on strings

* Add warning to use network_cli

(cherry picked from commit d5dbd8c)
@samdoran samdoran mentioned this pull request May 22, 2018
Merged
samdoran added a commit that referenced this pull request May 22, 2018
@samdoran
EdgeOS module improvements (#39530) (#40548)
4c279f5 
* Update docs and use to_text on strings

* Add warning to use network_cli

(cherry picked from commit d5dbd8c)
achinthagunasekara pushed a commit to achinthagunasekara/ansible that referenced this pull request May 23, 2018
@samdoran @achinthagunasekara
EdgeOS module improvements (ansible#39530)
be147cb 
* Update docs and use to_text on strings

* Add warning to use network_cli
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@samdoran
EdgeOS module improvements (ansible#39530)
869f942 
* Update docs and use to_text on strings

* Add warning to use network_cli
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@samdoran @ilicmilan
EdgeOS module improvements (ansible#39530)
c201403 
* Update docs and use to_text on strings

* Add warning to use network_cli
@ansible ansible locked and limited conversation to collaborators May 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Qalthos requested changes

Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EdgeOS commands not working on firmware 1.10.1 (EdgeRouter 6P)
4 participants
@samdoran @ansibot @Qalthos @maxamillion