vyos_interface require multiple network nodes to run #39670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have the ability to run these currently, so disable them. The original logic was also incorrect, the tests don't pass on lab, DCI nor single instance nodepool, so disable ansible#39667 tracks getting these enabled again
ansibot
added
bug
gundalow
removed
the
needs_triage
ganeshrn
reviewed
May 3, 2018
| vyos_command: | ||
| commands: | ||
| - lsmod | ||
| register: lsmod_out | ||
| - show lldp neighbors |
There was a problem hiding this comment.
This should be - show lldp neighbors detail
ganeshrn
reviewed
May 3, 2018
|
|
||
| - name: Should we run lldp tests? | ||
| set_fact: | ||
| run_lldp_tests: "'Gi0/0' in neighbors_out.stdout[0]" |
There was a problem hiding this comment.
run_lldp_tests: "'PortDescr: eth0' in neighbors_out.stdout[0]"
ganeshrn
reviewed
May 3, 2018
| @@ -28,14 +51,14 @@ | |||
| vyos_interface: | |||
| name: eth0 | |||
| neighbors: | |||
| - port: eth0 | |||
| when: "'virtio_net' not in lsmod_out.stdout[0]" | |||
| - port: Gi0/0 | |||
ganeshrn
reviewed
May 3, 2018
| @@ -108,30 +131,30 @@ | |||
| aggregate: | |||
| - name: eth0 | |||
| neighbors: | |||
| - port: eth0 | |||
| when: "'virtio_net' not in lsmod_out.stdout[0]" | |||
| - port: Gi0/0 | |||
ganeshrn
reviewed
May 3, 2018
|
|
||
| - name: Check lldp neighbors intent aggregate arguments (failed) | ||
| vyos_interface: | ||
| aggregate: | ||
| - name: eth0 | ||
| neighbors: | ||
| - port: eth0 | ||
| - port: Gi0/0 |
ganeshrn
approved these changes
May 3, 2018
gundalow
added a commit
to gundalow/ansible
that referenced
this pull request
May 3, 2018
* vyos_interface require multiple network nodes to run We don't have the ability to run these currently, so disable them. The original logic was also incorrect, the tests don't pass on lab, DCI nor single instance nodepool, so disable ansible#39667 tracks getting these enabled again * eth0 -> Gi0/0 * Correctly detect if we should run lldp * Correctly detect if we should run lldp (cherry picked from commit 923a81e)
gundalow
added a commit
that referenced
this pull request
May 3, 2018
* vyos_interface require multiple network nodes to run We don't have the ability to run these currently, so disable them. The original logic was also incorrect, the tests don't pass on lab, DCI nor single instance nodepool, so disable #39667 tracks getting these enabled again * eth0 -> Gi0/0 * Correctly detect if we should run lldp * Correctly detect if we should run lldp (cherry picked from commit 923a81e)
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 12, 2018
* vyos_interface require multiple network nodes to run We don't have the ability to run these currently, so disable them. The original logic was also incorrect, the tests don't pass on lab, DCI nor single instance nodepool, so disable ansible#39667 tracks getting these enabled again * eth0 -> Gi0/0 * Correctly detect if we should run lldp * Correctly detect if we should run lldp
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
* vyos_interface require multiple network nodes to run We don't have the ability to run these currently, so disable them. The original logic was also incorrect, the tests don't pass on lab, DCI nor single instance nodepool, so disable ansible#39667 tracks getting these enabled again * eth0 -> Gi0/0 * Correctly detect if we should run lldp * Correctly detect if we should run lldp
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
* vyos_interface require multiple network nodes to run We don't have the ability to run these currently, so disable them. The original logic was also incorrect, the tests don't pass on lab, DCI nor single instance nodepool, so disable ansible#39667 tracks getting these enabled again * eth0 -> Gi0/0 * Correctly detect if we should run lldp * Correctly detect if we should run lldp
tonal
pushed a commit
to tonal/ansible
that referenced
this pull request
May 15, 2018
* vyos_interface require multiple network nodes to run We don't have the ability to run these currently, so disable them. The original logic was also incorrect, the tests don't pass on lab, DCI nor single instance nodepool, so disable ansible#39667 tracks getting these enabled again * eth0 -> Gi0/0 * Correctly detect if we should run lldp * Correctly detect if we should run lldp
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
* vyos_interface require multiple network nodes to run We don't have the ability to run these currently, so disable them. The original logic was also incorrect, the tests don't pass on lab, DCI nor single instance nodepool, so disable ansible#39667 tracks getting these enabled again * eth0 -> Gi0/0 * Correctly detect if we should run lldp * Correctly detect if we should run lldp
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
* vyos_interface require multiple network nodes to run We don't have the ability to run these currently, so disable them. The original logic was also incorrect, the tests don't pass on lab, DCI nor single instance nodepool, so disable ansible#39667 tracks getting these enabled again * eth0 -> Gi0/0 * Correctly detect if we should run lldp * Correctly detect if we should run lldp
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
* vyos_interface require multiple network nodes to run We don't have the ability to run these currently, so disable them. The original logic was also incorrect, the tests don't pass on lab, DCI nor single instance nodepool, so disable ansible#39667 tracks getting these enabled again * eth0 -> Gi0/0 * Correctly detect if we should run lldp * Correctly detect if we should run lldp
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We don't have the ability to run these currently, so disable them.
The original logic was also incorrect, the tests don't pass on lab, DCI
nor single instance nodepool, so disable
#39667 tracks getting these
enabled again
ISSUE TYPE
COMPONENT NAME
vyos_interface
ANSIBLE VERSION