Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race conditions in Pure Storage FA volume, snapshot and hostgroup modules #39698

Merged
merged 1 commit into from
Jun 13, 2018
Merged

Fix race conditions in Pure Storage FA volume, snapshot and hostgroup modules #39698

merged 1 commit into from
Jun 13, 2018

Conversation

sdodsley
Copy link
Contributor

@sdodsley sdodsley commented May 3, 2018 •
edited

SUMMARY

Fix race conditions where multiple hosts could be trying to create or delete the same volume, snapshot or hostgroup at the same time.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

storage/purestorage/purefa_volume
storage/purestorage/purefa_hg
storage/purestorage/purefa_snap

ANSIBLE VERSION
2.5

@sdodsley sdodsley force-pushed the purefa_patches branch 2 times, most recently from 6c3ee83 to b9168d6 Compare May 3, 2018 20:11
@sdodsley sdodsley changed the title Fix race conditions in Pure Storage FA volume and hostgroup modules Fix race conditions in Pure Storage FA volume, snapshot and hostgroup modules May 3, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels May 3, 2018
@ansibot
Copy link
Contributor

ansibot commented May 3, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/storage/purestorage/purefa_hg.py:193:0: syntax-error invalid syntax (<string>, line 193)

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/storage/purestorage/purefa_hg.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/storage/purestorage/purefa_hg.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/storage/purestorage/purefa_hg.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/storage/purestorage/purefa_hg.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/storage/purestorage/purefa_hg.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/storage/purestorage/purefa_hg.py:193:24: SyntaxError: for vol in vols:

The test ansible-test sanity --test compile --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/storage/purestorage/purefa_hg.py:193:24: SyntaxError: for vol in vols:

The test ansible-test sanity --test compile --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/storage/purestorage/purefa_hg.py:193:24: SyntaxError: for vol in vols:

The test ansible-test sanity --test compile --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/storage/purestorage/purefa_hg.py:193:24: SyntaxError: for vol in vols:

The test ansible-test sanity --test compile --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/storage/purestorage/purefa_hg.py:193:24: SyntaxError: for vol in vols:

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "test/sanity/code-smell/docs-build.py", line 101, in <module>
    main()
  File "test/sanity/code-smell/docs-build.py", line 17, in main
    raise subprocess.CalledProcessError(sphinx.returncode, cmd, output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['make', 'singlehtmldocs']' returned non-zero exit status 2.

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/storage/purestorage/purefa_hg.py:193:24: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 2.7 [explain] failed with 2 errors:

lib/ansible/modules/storage/purestorage/purefa_hg.py:0:0: SyntaxError: invalid syntax (purefa_hg.py, line 193) (in /root/ansible/test/runner/.tox/minimal-py27/bin/importer.py:82)
lib/ansible/modules/storage/purestorage/purefa_hg.py:193:24: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.5 [explain] failed with 2 errors:

lib/ansible/modules/storage/purestorage/purefa_hg.py:0:0: SyntaxError: invalid syntax (purefa_hg.py, line 193) (in /root/ansible/test/runner/.tox/minimal-py35/bin/importer.py:82)
lib/ansible/modules/storage/purestorage/purefa_hg.py:193:24: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.6 [explain] failed with 2 errors:

lib/ansible/modules/storage/purestorage/purefa_hg.py:0:0: SyntaxError: invalid syntax (purefa_hg.py, line 193) (in /root/ansible/test/runner/.tox/minimal-py36/bin/importer.py:82)
lib/ansible/modules/storage/purestorage/purefa_hg.py:193:24: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 3.7 [explain] failed with 2 errors:

lib/ansible/modules/storage/purestorage/purefa_hg.py:0:0: SyntaxError: invalid syntax (purefa_hg.py, line 193) (in /root/ansible/test/runner/.tox/minimal-py37/bin/importer.py:82)
lib/ansible/modules/storage/purestorage/purefa_hg.py:193:24: SyntaxError: invalid syntax

The test ansible-test sanity --test pep8 [explain] failed with 29 errors:

lib/ansible/modules/storage/purestorage/purefa_hg.py:193:9: E128 continuation line under-indented for visual indent
lib/ansible/modules/storage/purestorage/purefa_hg.py:194:13: E128 continuation line under-indented for visual indent
lib/ansible/modules/storage/purestorage/purefa_hg.py:195:17: E128 continuation line under-indented for visual indent
lib/ansible/modules/storage/purestorage/purefa_hg.py:197:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/storage/purestorage/purefa_hg.py:197:26: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/storage/purestorage/purefa_hg.py:198:9: E122 continuation line missing indentation or outdented
lib/ansible/modules/storage/purestorage/purefa_hg.py:198:13: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/storage/purestorage/purefa_hg.py:198:15: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/storage/purestorage/purefa_hg.py:199:9: E122 continuation line missing indentation or outdented
lib/ansible/modules/storage/purestorage/purefa_hg.py:204:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/storage/purestorage/purefa_hg.py:204:26: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/storage/purestorage/purefa_hg.py:205:9: E122 continuation line missing indentation or outdented
lib/ansible/modules/storage/purestorage/purefa_hg.py:206:20: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/storage/purestorage/purefa_hg.py:206:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/storage/purestorage/purefa_hg.py:207:5: E122 continuation line missing indentation or outdented
lib/ansible/modules/storage/purestorage/purefa_hg.py:209:5: E122 continuation line missing indentation or outdented
lib/ansible/modules/storage/purestorage/purefa_hg.py:212:1: E122 continuation line missing indentation or outdented
lib/ansible/modules/storage/purestorage/purefa_hg.py:213:18: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/storage/purestorage/purefa_hg.py:213:20: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/storage/purestorage/purefa_hg.py:221:11: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/storage/purestorage/purefa_hg.py:221:13: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/storage/purestorage/purefa_hg.py:226:10: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/storage/purestorage/purefa_hg.py:226:12: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/storage/purestorage/purefa_hg.py:227:10: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/storage/purestorage/purefa_hg.py:227:12: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/storage/purestorage/purefa_hg.py:228:14: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/storage/purestorage/purefa_hg.py:228:16: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/storage/purestorage/purefa_hg.py:257:1: E122 continuation line missing indentation or outdented
lib/ansible/modules/storage/purestorage/purefa_hg.py:259:1: E901 TokenError: EOF in multi-line statement

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/purestorage/purefa_hg.py:0:0: E401 Python SyntaxError while parsing module

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/storage/purestorage/purefa_hg.py:193:24: python-syntax-error invalid syntax (<unknown>, line 193)

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. owner_pr This PR is made by the module's maintainer. labels May 3, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label May 3, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. owner_pr This PR is made by the module's maintainer. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 3, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 11, 2018
@ansibot ansibot added the affects_2.6 This issue/PR affects Ansible v2.6 label May 19, 2018
@ansibot ansibot added storage and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 12, 2018
@nitzmahone nitzmahone merged commit 8df02ac into ansible:devel Jun 13, 2018
@sdodsley sdodsley deleted the purefa_patches branch June 18, 2018 23:09
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@sdodsley
Fix race condifiton where multiple hosts can try and create or delete (…
0d131d9 
…ansible#39698)

the same volume, snapshot or hostgroup,
@ansible ansible locked and limited conversation to collaborators Jun 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone nitzmahone approved these changes

Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. storage support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sdodsley @ansibot @nitzmahone @samdoran