Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New module - meraki_admin #39837

Merged
merged 10 commits into from
May 26, 2018
Merged

New module - meraki_admin #39837

merged 10 commits into from
May 26, 2018

Conversation

kbreit
Copy link
Contributor

@kbreit kbreit commented May 8, 2018 •
edited

SUMMARY

meraki_admin allows for CRUD functionality related to administrators in a Meraki organization. Permissions can be assigned by organization, tag, or network

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

meraki/meraki_admin

ANSIBLE VERSION
ansible 2.6.0 (meraki/meraki_admin dba1921903) last updated 2018/05/07 20:51:55 (GMT -500)
  config file = None
  configured module search path = ['/Users/kbreit/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/kbreit/Documents/Programming/ansible/lib/ansible
  executable location = /Users/kbreit/Documents/Programming/ansible/bin/ansible
  python version = 3.5.4 (default, Feb 25 2018, 14:56:02) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)]
ADDITIONAL INFORMATION

Open items before merge:

  • Enable body error output in meraki module utility (PR 39838)
  • Improve module documentation

kbreit added 4 commits May 3, 2018 21:00
@kbreit
Initial commit for meraki_admin module
3e19e76
@kbreit
Added integration tests for administration tasks
74c08d2
@kbreit
Enabled full CRUD functionality for admins
b8c5c66 
- Uses a temporary function until get_nets is added to utils
- Depends on a patch to utils which adds body to errors
- network_factory() creates a network permission list
-
@kbreit
PEP8 changes
dba1921
@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. meraki Cisco Meraki community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels May 8, 2018
kbreit added 3 commits May 7, 2018 21:18
@kbreit
Added integration tests for delete functionality
4d9aeae 
- Delete works
- Changed URL
- Disabled assertions in test which won't pass for now
@kbreit
Check for idempotency
a0e1fd9 
- Module is idempotent for changes
- Integration tests idempotency against admin network changes
@kbreit
Improved documentation
886c4fd 
- Changed documentation strings to raw
- Wrote return value documentation for info condition
@ansibot
Copy link
Contributor

ansibot commented May 8, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/meraki/meraki_admin.py:147:24: W291 trailing whitespace

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label May 8, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label May 9, 2018
@kbreit kbreit changed the title [WIP] New module meraki_admin [WIP] New module - meraki_admin May 9, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label May 10, 2018
@ansibot
Copy link
Contributor

ansibot commented May 10, 2018

cc @dagwieers
click here for bot help

@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels May 18, 2018
@kbreit
Enhancements to integration test
ae7d31a 
- Email variables determine admin email address
- Added test for administrator with invalid network test
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 18, 2018
@kbreit
Copy link
Contributor Author

kbreit commented May 25, 2018

@dagwieers With today being freeze please merge if you’re happy with this.

@dagwieers
Copy link
Contributor

@kbreit In principle, you need to remove the [WIP] as it otherwise would look as if I am merging WIP code...

dagwieers
dagwieers approved these changes May 26, 2018
View reviewed changes
Copy link
Contributor

@dagwieers dagwieers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dagwieers dagwieers changed the title [WIP] New module - meraki_admin New module - meraki_admin May 26, 2018
@dagwieers dagwieers merged commit e16490c into ansible:devel May 26, 2018
gothicx pushed a commit to gothicx/ansible that referenced this pull request Jun 9, 2018
@kbreit @gothicx
[WIP] New module - meraki_admin (ansible#39837)
be1fc72 
New module - meraki_admin
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@kbreit
[WIP] New module - meraki_admin (ansible#39837)
b616fb6 
New module - meraki_admin
@kbreit kbreit deleted the meraki/meraki_admin branch September 28, 2018 16:01
@dagwieers dagwieers added the cisco Cisco technologies label Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators May 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dagwieers dagwieers dagwieers approved these changes

Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 cisco Cisco technologies meraki Cisco Meraki community module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kbreit @ansibot @dagwieers @jborean93