Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nxos become #39859

Merged
merged 1 commit into from
May 15, 2018
Merged

Nxos become #39859

merged 1 commit into from
May 15, 2018

Conversation

acozine
Copy link
Contributor

@acozine acozine commented May 8, 2018

SUMMARY

Updates network documentation to cover changes in #39355

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs.ansible.com

ANSIBLE VERSION

2.5
Will backport to stable-2.5

@acozine acozine added networking Network category docs This issue/PR relates to or includes documentation. labels May 8, 2018
@acozine acozine added this to Docsite work in Ansible-maintained Collections Documentation via automation May 8, 2018
@ansibot
Copy link
Contributor

ansibot commented May 8, 2018

@ansibot ansibot added the support:core This issue/PR relates to code supported by the Ansible Engineering Team. label May 8, 2018
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Do we want people to use authorize
  2. This functionality is only in 2.5.3 (?) onwards. That needs to be clearer in the docs

@trishnaguha How come this is getting backported, Is it counted as a bug fix, rather than feature work?

@@ -25,8 +25,9 @@ Connections Available
| | | | | | Requires ``transport: nxapi`` |
| | | | | | in the ``provider`` dictionary |
+---------------------------+-----------------------------------------------+-----------------------------------------+
| | **Enable Mode** | | not supported by NXOS | | not supported by NXOS |
| | (Privilege Escalation) | | | |
| | **Enable Mode** | | supported - use ``ansible_become: yes`` | | supported - use ``authorize: yes`` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note about 2.5.3 here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed by 119f45e286d59b54916965f7ce0aaec86bac57cf?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@acozine acozine moved this from Docsite work to In progress in Ansible-maintained Collections Documentation May 8, 2018
@trishnaguha
Copy link
Member

@gundalow bugfix

@trishnaguha
Copy link
Member

trishnaguha commented May 9, 2018

@gundalow @acozine authorize, auth_pass can be used with connecion: local transport cli. since we now support ansible-ish way for privilege escalation since 2.5, the doc looks good to me.
Just FYI nxapi code for enable mode isn't pushed yet. So the doc for nxapi needs to wait for now.

@@ -96,6 +100,8 @@ Example NX-API ``group_vars/nxos.yml``
nxapi:
host: "{{ inventory_hostname }}"
transport: nxapi
authorize: yes
auth_pass: !vault...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also needs to be removed from nxapi provider spec.

@acozine
Copy link
Contributor Author

acozine commented May 14, 2018

Per discussion with the cisco nxos team, nxapi itself doesn't support enable mode - reflected in the docs.

@gundalow gundalow merged commit 64f8786 into ansible:devel May 15, 2018
Ansible-maintained Collections Documentation automation moved this from In progress to Done May 15, 2018
@acozine acozine moved this from Done to Needs Backport to 2.5 in Ansible-maintained Collections Documentation May 15, 2018
@gundalow
Copy link
Contributor

Please backport into stable-2.5

@trishnaguha trishnaguha moved this from Needs Backport to 2.5 to Done in Ansible-maintained Collections Documentation May 16, 2018
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request May 16, 2018
@trishnaguha
Copy link
Member

trishnaguha commented May 16, 2018

cherry-picked to 2.5 #40221

trishnaguha added a commit that referenced this pull request May 16, 2018
@acozine acozine deleted the nxos_become branch May 30, 2018 16:01
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@dagwieers dagwieers added nxos Cisco NXOS community cisco Cisco technologies labels Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators May 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cisco Cisco technologies docs This issue/PR relates to or includes documentation. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants