-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honor ignore_errors when invoking the debugger, add config to disable this behavior #39868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… this behavior. Fixes ansible#39863
ansibot
added
feature
This issue/PR relates to a feature request.
needs_triage
Needs a first human triage before being processed.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
labels
May 8, 2018
bcoca
reviewed
May 8, 2018
lib/ansible/executor/task_result.py
Outdated
ret = True | ||
elif _debugger in ('on_unreachable',) and self.is_unreachable(): | ||
elif _debugger in ('on_unreachable',) and self.is_unreachable() and not _ignore_errors: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignore_errors doesn't normally cover unreachable
ansibot
added
the
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
label
May 8, 2018
ssbarnea
approved these changes
May 9, 2018
ansibot
removed
the
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
label
May 11, 2018
ansibot
added
affects_2.6
This issue/PR affects Ansible v2.6
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
labels
May 19, 2018
rebuild_merge |
ansibot
added
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
and removed
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
labels
May 31, 2018
jacum
pushed a commit
to jacum/ansible
that referenced
this pull request
Jun 26, 2018
… this behavior (ansible#39868) * Honor ignore_errors when invoking the debugger, add config to disable this behavior. Fixes ansible#39863 * Limit ignore_errors logic to failed
Maybe I don't quite follow this, but I am using Ansible 2.7.6, and when I trigger an error on a task that has ignore_errors: true, I am still getting output from the debugger. ie.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.6
This issue/PR affects Ansible v2.6
feature
This issue/PR relates to a feature request.
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Honor ignore_errors when invoking the debugger, add config to disable this behavior. Fixes #39863
ISSUE TYPE
COMPONENT NAME
lib/ansible/config/base.yml
lib/ansible/executor/task_result.py
ANSIBLE VERSION
ADDITIONAL INFORMATION