Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for bigip_gtm_wide_ip #39931

Merged
merged 1 commit into from
May 10, 2018
Merged

Fixes for bigip_gtm_wide_ip #39931

merged 1 commit into from
May 10, 2018

Conversation

caphrim007
Copy link
Contributor

SUMMARY

Added the irules parameter. Misc corrections of invalid parameter
names and internal behaviors.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

bigip_gtm_wide_ip

ANSIBLE VERSION
ansible 2.6.0
  config file = None
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.6/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.6.4 (default, Mar 14 2018, 17:49:05) [GCC 4.9.2]
ADDITIONAL INFORMATION

@caphrim007 caphrim007 force-pushed the bugfix.bigip-gtm-wide-ip-fixes branch from e5f0f3a to 6fe9f43 Compare May 9, 2018 22:04
@ansibot
Copy link
Contributor

ansibot commented May 9, 2018

cc @Qalthos @ganeshrn @gdpak @gundalow @mattclay @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. f5 module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category python3 support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels May 9, 2018
@ansibot
Copy link
Contributor

ansibot commented May 9, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/f5/bigip_gtm_wide_ip.py:0:0: E326 Value for "choices" from the argument_spec (['return_to_dns', 'null', 'round_robin', 'static_persist', 'global_availability', 'vs_capacity', 'least_conn', 'lowest_rtt', 'lowest_hops', 'packet_rate', 'cpu', 'hit_ratio', 'qos', 'bps', 'drop_packet', 'explicit_ip', 'connection_rate', 'vs_score', 'round-robin', 'topology', 'ratio', 'global-availability']) for "pool_lb_method" does not match the documentation (['round-robin', 'ratio', 'topology', 'global-availability'])

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels May 9, 2018
@caphrim007 caphrim007 removed the needs_triage Needs a first human triage before being processed. label May 9, 2018
@caphrim007
Fixes for bigip_gtm_wide_ip
1b4b4d2 
Added the irules parameter. Misc corrections of invalid parameter
names and internal behaviors.
@caphrim007 caphrim007 force-pushed the bugfix.bigip-gtm-wide-ip-fixes branch from 6fe9f43 to 1b4b4d2 Compare May 9, 2018 23:53
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 9, 2018
@caphrim007 caphrim007 merged commit ad5fdf5 into ansible:devel May 10, 2018
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 12, 2018
@caphrim007
Fixes for bigip_gtm_wide_ip (ansible#39931)
2e24206 
Added the irules parameter. Misc corrections of invalid parameter
names and internal behaviors.
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@caphrim007
Fixes for bigip_gtm_wide_ip (ansible#39931)
a0f097c 
Added the irules parameter. Misc corrections of invalid parameter
names and internal behaviors.
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@caphrim007
Fixes for bigip_gtm_wide_ip (ansible#39931)
b053ae4 
Added the irules parameter. Misc corrections of invalid parameter
names and internal behaviors.
tonal pushed a commit to tonal/ansible that referenced this pull request May 15, 2018
@caphrim007
Fixes for bigip_gtm_wide_ip (ansible#39931)
425f6c8 
Added the irules parameter. Misc corrections of invalid parameter
names and internal behaviors.
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@caphrim007
Fixes for bigip_gtm_wide_ip (ansible#39931)
386e662 
Added the irules parameter. Misc corrections of invalid parameter
names and internal behaviors.
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@caphrim007
Fixes for bigip_gtm_wide_ip (ansible#39931)
48d3928 
Added the irules parameter. Misc corrections of invalid parameter
names and internal behaviors.
@caphrim007 caphrim007 deleted the bugfix.bigip-gtm-wide-ip-fixes branch August 28, 2018 17:12
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@caphrim007 @ilicmilan
Fixes for bigip_gtm_wide_ip (ansible#39931)
5cfad5a 
Added the irules parameter. Misc corrections of invalid parameter
names and internal behaviors.
@ansible ansible locked and limited conversation to collaborators May 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. f5 module This issue/PR relates to a module. networking Network category python3 support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@caphrim007 @ansibot