Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

letsencrypt: test issue #39997

Closed
ffdybuster opened this issue May 11, 2018 · 7 comments
Closed

letsencrypt: test issue #39997

ffdybuster opened this issue May 11, 2018 · 7 comments
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. crypto Crypto community (ACME, openssl, letsencrypt) deprecated This issue/PR relates to a deprecated module. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.

Comments

@ffdybuster
Copy link

ISSUE TYPE
  • Bug Report
COMPONENT NAME

letsencrypt

ANSIBLE VERSION
2.5.0
SUMMARY

This is a test to see whether the correct persons are pinged after the letsencrypt module was renamed.

@ansibot
Copy link
Contributor

ansibot commented May 11, 2018

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented May 11, 2018

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. deprecated This issue/PR relates to a deprecated module. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels May 11, 2018
@felixfontein
Copy link
Contributor

@resmo I did a test, it looks like only @mgruener is pinged for new letsencrypt-related tickets (probably because he is mentioned in _letsencrypt.py as author). That's not exactly optimal :-)

@mkrizek
Copy link
Contributor

mkrizek commented May 11, 2018

@felixfontein @ffdybuster who should be pinged for lib/ansible/modules/web_infrastructure/_letsencrypt.py? I can update the bot metadata for that.

@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label May 11, 2018
@felixfontein
Copy link
Contributor

@mkrizek the same people as for lib/ansible/modules/web_infrastructure/acme_certificate.py (lib/ansible/modules/web_infrastructure/_letsencrypt.py is a symlink to that file), i.e. @mgruener, @resmo and me (@felixfontein).

(Background: we renamed the letsencrypt module to acme_certifiate in #39816 and kept the symlink so that people can continue to use the old module name for some time. We weren't sure what happens if someone opens an issue for the old module name and decided to change the bot meta. Apparently we should have kept the old entry, or adjusted it.)

@mkrizek
Copy link
Contributor

mkrizek commented May 11, 2018

@felixfontein Ah, ok. Looks like we should add the botmeta entry back then. You want to send the PR or should I?

@felixfontein
Copy link
Contributor

@mkrizek I can do that. Just give me a minute :)

@dagwieers dagwieers added the crypto Crypto community (ACME, openssl, letsencrypt) label Feb 7, 2019
@ansible ansible locked and limited conversation to collaborators May 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. crypto Crypto community (ACME, openssl, letsencrypt) deprecated This issue/PR relates to a deprecated module. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

No branches or pull requests

5 participants