Make Cloudstack paging work for listVirtualMachines

[pfarmer]

Cloudstack paging wasn't supported, so once a cs domain has over 500 (default page size) VMs, Ansible can no longer find newly created VM.

SUMMARY

Cloudstack paging wasn't supported, so once a cs domain has over 500 (default page size) VMs, Ansible can no longer find newly created VM.

Paging is supported in the cs module, the cs module abstracts away the pages, and returns a list of the VMs. The normal cloudstack response contains a "count" variable (the count of virtualmachines in the domain), and a list of the virtualmachines, when paging, the cs module just returns a list of virtualmachines, so some small changes needed to be made to remove the reference to the "virtualmachine" key.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

cloudstack

ANSIBLE VERSION

[root@173d518834c1 playbook]# ansible --version
ansible 2.6.0
  config file = None
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, Apr 11 2018, 07:36:10) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]

ADDITIONAL INFORMATION

Before this change, once 500 VMs exists in the domain, the following error is seen.

fatal: [server38]: FAILED! => {"api_http_method": "get", "api_key": "******", "api_region": "cloudstack", "api_timeout": "30", "api_url": "http://172.17.0.2:8080/client/api", "changed": false, "msg": "Virtual machine 'server38' not found", "zone": "Sandbox-simulator"}

[ansibot]

cc @DazWorrall @dpassante @resmo
click here for bot help

[dj-wasabi]

I'm all for this PR! 👍

[resmo]

LGTM

Makes things even easier. Let's work towards for full pagination support in all modules.

[pfarmer]

@resmo I’ll have a look through the rest of the cloudstack related code next week to what else might need this change.

[resmo]

@pfarmer nice, looking forward and thanks for your contribution!