Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network requirements to be installed by ansible-test #40042

Merged
merged 1 commit into from
May 12, 2018
Merged

Network requirements to be installed by ansible-test #40042

merged 1 commit into from
May 12, 2018

Conversation

gundalow
Copy link
Contributor

SUMMARY

Previously the test framework (DCI, Zuul) were installing the various
dependencies, this meant the list of what was required was duplicated.

Having everything defined in ansible-test makes it easier for people to
run tests locally.

Also this allows the test to work correctly on Python 2 & Python 3

ISSUE TYPE
  • Bugfix Pull Request

@gundalow
Network requirements to be installed by ansible-test
125d4e9 
Previously the test framework (DCI, Zuul) were installing the various
dependencies, this meant the list of what was required was duplicated.

Having everything defined in ansible-test makes it easier for people to
run tests locally.

Also this allows the test to work correctly on Python 2 & Python 3
@ansibot
Copy link
Contributor

ansibot commented May 12, 2018

cc @mattclay
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels May 12, 2018
@gundalow
Copy link
Contributor Author

Will need to be backported into stable-2.5
Once merged ansible-zuul-jobs/roles/ansible-test-network-integration/tasks/main.yaml will need updating so we don't install dependencies there

@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label May 12, 2018
@gundalow gundalow merged commit 27942d9 into ansible:devel May 12, 2018
@gundalow gundalow deleted the network-pip-requirements branch May 12, 2018 09:13
@gundalow gundalow added this to Need CP into 2.5.3 in zzz NOT USED: Networking Bugs May 12, 2018
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 12, 2018
@gundalow
Network requirements to be installed by ansible-test (ansible#40042)
5a713a6 
Previously the test framework (DCI, Zuul) were installing the various
dependencies, this meant the list of what was required was duplicated.

Having everything defined in ansible-test makes it easier for people to
run tests locally.

Also this allows the test to work correctly on Python 2 & Python 3
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@gundalow
Network requirements to be installed by ansible-test (ansible#40042)
cf4ccb0 
Previously the test framework (DCI, Zuul) were installing the various
dependencies, this meant the list of what was required was duplicated.

Having everything defined in ansible-test makes it easier for people to
run tests locally.

Also this allows the test to work correctly on Python 2 & Python 3
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@gundalow
Network requirements to be installed by ansible-test (ansible#40042)
75946ad 
Previously the test framework (DCI, Zuul) were installing the various
dependencies, this meant the list of what was required was duplicated.

Having everything defined in ansible-test makes it easier for people to
run tests locally.

Also this allows the test to work correctly on Python 2 & Python 3
tonal pushed a commit to tonal/ansible that referenced this pull request May 15, 2018
@gundalow
Network requirements to be installed by ansible-test (ansible#40042)
81ff122 
Previously the test framework (DCI, Zuul) were installing the various
dependencies, this meant the list of what was required was duplicated.

Having everything defined in ansible-test makes it easier for people to
run tests locally.

Also this allows the test to work correctly on Python 2 & Python 3
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@gundalow
Network requirements to be installed by ansible-test (ansible#40042)
17e12d8 
Previously the test framework (DCI, Zuul) were installing the various
dependencies, this meant the list of what was required was duplicated.

Having everything defined in ansible-test makes it easier for people to
run tests locally.

Also this allows the test to work correctly on Python 2 & Python 3
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@gundalow
Network requirements to be installed by ansible-test (ansible#40042)
fbb1ad7 
Previously the test framework (DCI, Zuul) were installing the various
dependencies, this meant the list of what was required was duplicated.

Having everything defined in ansible-test makes it easier for people to
run tests locally.

Also this allows the test to work correctly on Python 2 & Python 3
gundalow added a commit to gundalow/ansible that referenced this pull request May 16, 2018
@gundalow
Network requirements to be installed by ansible-test (ansible#40042)
199ec21 
Previously the test framework (DCI, Zuul) were installing the various
dependencies, this meant the list of what was required was duplicated.

Having everything defined in ansible-test makes it easier for people to
run tests locally.

Also this allows the test to work correctly on Python 2 & Python 3
(cherry picked from commit 27942d9)
@gundalow gundalow moved this from Need CP into 2.5.3 to Done in zzz NOT USED: Networking Bugs May 16, 2018
gundalow added a commit that referenced this pull request May 16, 2018
@gundalow
Network requirements to be installed by ansible-test (#40042) (#40250)
4924398 
Previously the test framework (DCI, Zuul) were installing the various
dependencies, this meant the list of what was required was duplicated.

Having everything defined in ansible-test makes it easier for people to
run tests locally.

Also this allows the test to work correctly on Python 2 & Python 3
(cherry picked from commit 27942d9)
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@gundalow @ilicmilan
Network requirements to be installed by ansible-test (ansible#40042)
d9f0122 
Previously the test framework (DCI, Zuul) were installing the various
dependencies, this meant the list of what was required was duplicated.

Having everything defined in ansible-test makes it easier for people to
run tests locally.

Also this allows the test to work correctly on Python 2 & Python 3
@ansible ansible locked and limited conversation to collaborators May 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay Awaiting requested review from mattclay

@ganeshrn ganeshrn Awaiting requested review from ganeshrn

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
No open projects
zzz NOT USED: Networking Bugs
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gundalow @ansibot