Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #38787: azure_rm_resourcegroup idempotency broke when specifying location #40055

Merged
merged 1 commit into from
May 14, 2018
Merged

Fixes #38787: azure_rm_resourcegroup idempotency broke when specifying location #40055

merged 1 commit into from
May 14, 2018

Conversation

yuwzho
Copy link
Contributor

@yuwzho yuwzho commented May 13, 2018

SUMMARY

User can set location as the display name, but it will break the idempotent,

Fixes #38787

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm-resourcegroup.py

ANSIBLE VERSION
2.5.2
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented May 13, 2018

cc @haroldwongms @nitzmahone @trstringer @xscript @zikalino
click here for bot help

@ansibot ansibot added azure bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:certified This issue/PR relates to certified code. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 13, 2018
@yuwzho
Copy link
Contributor Author

yuwzho commented May 13, 2018 •
edited

Try this PR's change by installing ansible role via git

ansible-galaxy install git+https://github.com/Azure/azure_preview_modules.git,yuwzho-rg

Try the PR by using devel branch pip install git+https://github.com/ansible/ansible.git@devel

@ansibleazurebot ansibleazurebot mentioned this pull request May 14, 2018
Closed
zikalino
zikalino reviewed May 14, 2018
View reviewed changes
lib/ansible/modules/cloud/azure/azure_rm_resourcegroup.py
@@ -162,7 +162,7 @@ def exec_module(self, **kwargs):
if update_tags:
changed = True

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was wondering, perhaps we could normalize location before, e.g.:

self.location = normalize_location_name(self.location)

but just a suggestion. not sure perhaps that would have some disadvantages...

@zikalino zikalino merged commit c84e3e7 into ansible:devel May 14, 2018
@zikalino zikalino deleted the yuwzho-rg branch May 14, 2018 03:47
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@yuwzho
location name (ansible#40055)
1812a69
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@yuwzho
location name (ansible#40055)
e0636ba
tonal pushed a commit to tonal/ansible that referenced this pull request May 15, 2018
@yuwzho
location name (ansible#40055)
e003f0a
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label May 15, 2018
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@yuwzho
location name (ansible#40055)
edf1590
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@yuwzho
location name (ansible#40055)
5229ef2
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@yuwzho @ilicmilan
location name (ansible#40055)
e205e3e
@ansible ansible locked and limited conversation to collaborators May 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zikalino zikalino zikalino approved these changes

Assignees
No one assigned
Labels
azure bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:certified This issue/PR relates to certified code. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

azure_rm_resourcegroup idempotency broke when specifying location
4 participants
@yuwzho @ansibot @zikalino @bcoca