Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better handling for errors causing integration test instability #40184

Merged
merged 2 commits into from
May 15, 2018
Merged

Add better handling for errors causing integration test instability #40184

merged 2 commits into from
May 15, 2018

Conversation

ryansb
Copy link
Contributor

@ryansb ryansb commented May 15, 2018

SUMMARY

Per #40175

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_vpc_vgw
ec2_customer_gateway

ANSIBLE VERSION
ADDITIONAL INFORMATION

@ryansb ryansb requested a review from s-hertel May 15, 2018 17:51
@ansibot
Copy link
Contributor

ansibot commented May 15, 2018

cc @MichaelBaydoun @MichaelBaydoun @naslanidis
click here for bot help

@ansibot ansibot added aws bug This issue/PR relates to a bug. cloud committer_review In order to be merged, this PR must follow the certified review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:certified This issue/PR relates to certified code. support:community This issue/PR relates to code supported by the Ansible community. labels May 15, 2018
@ryansb ryansb removed the needs_triage Needs a first human triage before being processed. label May 15, 2018
@ansibot
Copy link
Contributor

ansibot commented May 15, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_customer_gateway.py:151:5: undefined-variable Undefined variable 'AWSRetry'

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_customer_gateway.py:151:0: NameError: name 'AWSRetry' is not defined

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_customer_gateway.py:151:0: NameError: name 'AWSRetry' is not defined

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_customer_gateway.py:151:0: NameError: name 'AWSRetry' is not defined

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_customer_gateway.py:151:0: NameError: name 'AWSRetry' is not defined

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_customer_gateway.py:151:0: NameError: name 'AWSRetry' is not defined

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ec2_customer_gateway.py:0:0: E321 Exception attempting to import module for argument_spec introspection, 'name 'AWSRetry' is not defined'

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed committer_review In order to be merged, this PR must follow the certified review workflow. labels May 15, 2018
@ansibot ansibot added committer_review In order to be merged, this PR must follow the certified review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 15, 2018
@s-hertel s-hertel merged commit ede4791 into ansible:devel May 15, 2018
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@ryansb
Add better handling for errors causing integration test instability (a…
89d815a 
…nsible#40184)

* Add better handling for errors causing integration test instability
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@ryansb @ilicmilan
Add better handling for errors causing integration test instability (a…
f5cac0c 
…nsible#40184)

* Add better handling for errors causing integration test instability
@ansible ansible locked and limited conversation to collaborators May 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
aws bug This issue/PR relates to a bug. cloud committer_review In order to be merged, this PR must follow the certified review workflow. module This issue/PR relates to a module. support:certified This issue/PR relates to certified code. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryansb @ansibot @s-hertel