Module basic.py to create parent dirs of tmpdir if needed #40201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bug
ansibot
added
the
needs_revision
|
Code looks good. I'd assert whether makedirs is called and also add a case where the path already exists (and assert that makedirs is not called in that case). |
This was referenced May 16, 2018
abadger
reviewed
May 16, 2018
| @@ -51,7 +51,16 @@ class TestAnsibleModuleTmpDir: | |||
| def test_tmpdir_property(self, am, monkeypatch, expected): | |||
| def mock_mkdtemp(prefix, dir): | |||
| return os.path.join(dir, prefix) | |||
|
|
|||
There was a problem hiding this comment.
makedirs_called = 0
def mock_makedirs(path, mode):
makedirs_called += 1
expected = os.path.expanduser(os.path.expandvars(am._remote_tmp))
assert path == expected
assert mode = 0o700
returnThere was a problem hiding this comment.
And then after line 71:
assert makedirs_called == 1
jborean93
force-pushed
the
module-tmpdir-pipelining
branch
from
4155ae8
to
d4be23c
Compare
ansibot
removed
the
needs_revision
|
From #40168 (comment)
|
mkrizek
removed
the
needs_triage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When pipelining is enabled and the path at
remote_tmpdoes not already exists,module.tmpdirwill fail to create the tmp directory. This change will ensure the parent dirs exists before creating that module tmp directory.Fixes #40168
ISSUE TYPE
COMPONENT NAME
module_utils/basic.py
ANSIBLE VERSION