Lenovo cli expansion - Modify command acronyms to full commands #40218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 16, 2018 12:14
ansibot
added
bug
gundalow
approved these changes
May 16, 2018
gundalow
pushed a commit
to gundalow/ansible
that referenced
this pull request
May 16, 2018
…ble#40218) * Changing Lenovo Inc to Lenovo and update License file to be consistent. * Editing cli commands to expanded form. Changing username and password fields as per Ansible standards. (cherry picked from commit f60731e)
|
PR for 2.5 #40254 |
|
Merged into |
mkrizek
removed
the
needs_triage
jacum
pushed a commit
to jacum/ansible
that referenced
this pull request
Jun 26, 2018
…ble#40218) * Changing Lenovo Inc to Lenovo and update License file to be consistent. * Editing cli commands to expanded form. Changing username and password fields as per Ansible standards.
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
…ble#40218) * Changing Lenovo Inc to Lenovo and update License file to be consistent. * Editing cli commands to expanded form. Changing username and password fields as per Ansible standards.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Starting with our recent CNOS release version 10.7, we have moved certain CLI keywords to match with Industry Standard CLI (ISCLI) keywords. For backward compatibility, old CLI keywords will continue to work for next one or two CNOS releases with a condition that “command acronyms” of old CLI keywords, cannot be used. For eg: Use “display version” instead of “disp ver”. This PR is to expand the acronymns if they are present in the python code
This has to be backported to 2.5 as well.
ISSUE TYPE
COMPONENT NAME
lib\ansible\modules\network\cnos\cnos_backup.py
lib\ansible\modules\network\cnos\cnos_bgp.py
lib\ansible\modules\network\cnos\cnos_conditional_command.py
lib\ansible\modules\network\cnos\cnos_conditional_template.py
lib\ansible\modules\network\cnos\cnos_factory.py
lib\ansible\modules\network\cnos\cnos_image.py
lib\ansible\modules\network\cnos\cnos_interface.py
lib\ansible\modules\network\cnos\cnos_portchannel.py
lib\ansible\modules\network\cnos\cnos_reload.py
lib\ansible\modules\network\cnos\cnos_rollback.py
lib\ansible\modules\network\cnos\cnos_save.py
lib\ansible\modules\network\cnos\cnos_showrun.py
lib\ansible\modules\network\cnos\cnos_template.py
lib\ansible\modules\network\cnos\cnos_vlag.py
lib\ansible\modules\network\cnos\cnos_vlan.py
ANSIBLE VERSION
ansible 2.6.0
config file = /etc/ansible/ansible.cfg
configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/sha re/ansible/plugins/modules']
ansible python module location = /usr/local/lib/python2.7/dist-packages/ansibl e-2.6.0-py2.7.egg/ansible
executable location = /usr/local/bin/ansible
python version = 2.7.6 (default, Nov 23 2017, 15:49:48) [GCC 4.8.4]
ADDITIONAL INFORMATION
Tried to change the documentation where the user has to use anisble_ssh_user and ansible_user_pass instead of username and password.