Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify in docs that end_play affects all hosts #40235

Merged
merged 1 commit into from
May 17, 2018
Merged

Clarify in docs that end_play affects all hosts #40235

merged 1 commit into from
May 17, 2018

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented May 16, 2018

SUMMARY

Confusion mentioned in #32785

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

meta

ANSIBLE VERSION
devel
ADDITIONAL INFORMATION

@mkrizek mkrizek requested review from jimi-c and bcoca May 16, 2018 10:40
@mkrizek mkrizek added this to READY TO REVIEW in CEM May 16, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 16, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label May 17, 2018
@jborean93 jborean93 merged commit b116eaa into ansible:devel May 17, 2018
@jborean93
Copy link
Contributor

Thanks @mkrizek are you able to backport to stable-2.5 so the latest docs show this?

@mkrizek mkrizek deleted the docs-meta-clarify-end_play branch May 17, 2018 08:41
@mkrizek mkrizek moved this from READY TO REVIEW to DONE in CEM May 17, 2018
mkrizek added a commit to mkrizek/ansible that referenced this pull request May 17, 2018
@mkrizek
Clarify in docs that end_play affects all hosts (ansible#40235)
d61b159 
(cherry picked from commit b116eaa)
@mkrizek mkrizek mentioned this pull request May 17, 2018
Merged
mkrizek added a commit that referenced this pull request May 21, 2018
@mkrizek
Clarify in docs that end_play affects all hosts (#40235) (#40306)
d60f70b 
(cherry picked from commit b116eaa)
achinthagunasekara pushed a commit to achinthagunasekara/ansible that referenced this pull request May 23, 2018
@mkrizek @achinthagunasekara
Clarify in docs that end_play affects all hosts (ansible#40235)
266b4d4
@tyll
Copy link
Contributor

tyll commented May 28, 2018

@mkrizek as reported in #27973 there is another issue with end_play: If a when: condition does not match the first host in the inventory but only other hosts, it does not end the play for any host.

jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@mkrizek
Clarify in docs that end_play affects all hosts (ansible#40235)
24812e6
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@mkrizek @ilicmilan
Clarify in docs that end_play affects all hosts (ansible#40235)
7573c3c
@ansible ansible locked and limited conversation to collaborators May 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jimi-c jimi-c Awaiting requested review from jimi-c

@bcoca bcoca Awaiting requested review from bcoca

Assignees
No one assigned
Labels
core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
CEM
DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mkrizek @jborean93 @tyll @ansibot