Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_hostname: Add new win_hostname module #40295

Merged
merged 1 commit into from May 17, 2018
Merged

win_hostname: Add new win_hostname module #40295

merged 1 commit into from May 17, 2018

Conversation

jborean93
Copy link
Contributor

SUMMARY

This is a continuation of #36021 that fixes some of the outstanding issues and adds integration tests. Thanks @riponbanik for the work you did here.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

win_hostname

ANSIBLE VERSION
devel

@ansibot
Copy link
Contributor

ansibot commented May 17, 2018

cc @dagwieers @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. windows Windows community labels May 17, 2018
@jborean93 jborean93 mentioned this pull request May 17, 2018
Closed
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 17, 2018
@riponbanik @jborean93
Add windows module for changing the hostname
88a229c 
Co-authored-by: Ripon Banik <riponbanik@users.noreply.github.com>
@jborean93 jborean93 merged commit 2f70360 into ansible:devel May 17, 2018
@jborean93 jborean93 deleted the win_hostname-module branch May 17, 2018 01:41
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label May 18, 2018
@riponbanik
Copy link
Contributor

Thanks a lot @jborean93 for your guidance and assistance

jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@jborean93 @riponbanik
Add windows module for changing the hostname (ansible#40295)
274337c 
Co-authored-by: Ripon Banik <riponbanik@users.noreply.github.com>
@dagwieers dagwieers mentioned this pull request Jul 11, 2018
Closed
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@jborean93 @riponbanik @ilicmilan
Add windows module for changing the hostname (ansible#40295)
a746b8e 
Co-authored-by: Ripon Banik <riponbanik@users.noreply.github.com>
@ansible ansible locked and limited conversation to collaborators May 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jborean93 @ansibot @riponbanik @mkrizek