Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SVI Example for Arista EOS platform #40349

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

JacksonIsaac
Copy link
Contributor

@JacksonIsaac JacksonIsaac commented May 17, 2018

SUMMARY

Add SVI Example for Arista EOS platform

Refers #40323 and ansible/community#311

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

eos_l3_interface

ANSIBLE VERSION
ansible 2.6.0
  config file = None
  configured module search path = ['/Users/jacksonisaac/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /anaconda3/lib/python3.6/site-packages/ansible-2.6.0-py3.6.egg/ansible
  executable location = /anaconda3/bin/ansible
  python version = 3.6.4 |Anaconda, Inc.| (default, Jan 16 2018, 12:04:33) [GCC 4.2.1 Compatible Clang 4.0.1 (tags/RELEASE_401/final)]
ADDITIONAL INFORMATION

N/A. Just replicating #40021

@ansibot
Copy link
Contributor

ansibot commented May 17, 2018

@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. python3 support:network This issue/PR relates to code supported by the Ansible Network Team. labels May 17, 2018
@acozine acozine self-requested a review May 17, 2018 20:01
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label May 17, 2018
@JacksonIsaac JacksonIsaac changed the title Add SVI Example for CISCO for eos/eos_l3_interface Add SVI Example for Arista EOS platform May 18, 2018
@IPvSean
Copy link
Contributor

IPvSean commented May 21, 2018

@JacksonIsaac based on the speed and have 5 identical pull requests I think we are going to institute a new policy for pull requests for the contest. I went ahead and "tested" this one for you to show you what we are looking for since I was not clear. Tagging @gundalow and @acozine for awareness and commentary.

This is still super easy, I just want pull requests to do the bare minimum of testing->

  • provide the output of the playbook being run
  • run the show command on the network device so we know the playbook was actually executed

For this pull request->

➜  ansible-napalm-samples git:(master) ✗ ansible-playbook test.yml

PLAY [arista] ********************************************************************************************************************************************************************

TASK [Set interface Vlan1 (SVI) IPv4 address] ************************************************************************************************************************************
changed: [eos]

PLAY RECAP ***********************************************************************************************************************************************************************
eos                        : ok=1    changed=1    unreachable=0    failed=0

and I can check that it ran properly->

eos#sh run int vlan1
interface Vlan1
   ip address 192.168.0.5/24

and we will go ahead and accept this pull request now that it is tested, I would like you to provide the output for the 4 other pull requests.

@JacksonIsaac
Copy link
Contributor Author

Hi @IPvSean I was actually stuck at setting up the environment due to limited internet. I tried to boot up a VM on AWS so that I don't need to worry about network issues etc. but was unable to do so.

I even tried to use VyOS VMI and again didn't understand how exactly I could setup vagrant and vbox, so tried to run a Windows RDP on AWS and was still figuring things out.

@IPvSean
Copy link
Contributor

IPvSean commented May 21, 2018

@JacksonIsaac
Copy link
Contributor Author

@IPvSean Yes I was following this link only as mentioned by you on one of the other PRs :)

@JacksonIsaac
Copy link
Contributor Author

Just figuring out to setup the environment on Cloud VM

@JacksonIsaac
Copy link
Contributor Author

JacksonIsaac commented May 21, 2018

@IPvSean Any way I can test this ansible-playbook on AWS (or any other cloud platform) for different OSes I have opened PR for ? I am having difficulty setting up vagrant on my local machine.

@JacksonIsaac
Copy link
Contributor Author

I have followed the steps given in the vagrant-demo link and tried to run the exercise01/backup.yml. I kept on getting some or the other error while setting up the complete cluser of leaf0x, spine0x and ansible. I then modified the Vagrantfile to run only VyOS i.e., leaf01 and tried ansible-playbook backup.yml -u vagrant -k

It keeps on giving an error saying

[WARNING]: Unable to parse /etc/ansible/hosts as an inventory source

[WARNING]: No inventory was parsed, only implicit localhost is available

[WARNING]: provided hosts list is empty, only localhost is available. Note that the implicit localhost does not match 'all'

PLAY [network] **********************************************************************************************************************************************************************

skipping: no hosts matched

I also tried putting the following code in Vagrantfile itself and still couldn't figure out where I am going wrong.

config.vm.provision "ansible" do |ansible|  
  ansible.verbose = "v"
  ansible.playbook = "training-course/exercise01/backup.yml"
end

@JacksonIsaac
Copy link
Contributor Author

Ah okay, I figured this step out. I had to run vagrant provision leaf01 and it executed the ansible playbook for me :)

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 26, 2018
@acozine acozine self-assigned this May 30, 2018
@IPvSean
Copy link
Contributor

IPvSean commented Jun 4, 2018

hey @JacksonIsaac this PR is good, please continue conversations about problems (e.g. VyOS) on the respective PR. This Arista one looks good and I am going to tell @acozine to accept the PR!

@acozine
Copy link
Contributor

acozine commented Jun 5, 2018

Thanks @JacksonIsaac for contributing to the documentation!

@acozine acozine merged commit 3d63128 into ansible:devel Jun 5, 2018
Ansible-maintained Collections Documentation automation moved this from Supported Modules Maintenance to Done Jun 5, 2018
@acozine acozine moved this from Done to Needs Backport to 2.6 in Ansible-maintained Collections Documentation Jun 8, 2018
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@samccann samccann moved this from Needs Backport to 2.6 to Needs Backport to 2.7 in Ansible-maintained Collections Documentation Dec 10, 2018
@samccann samccann moved this from Needs Backport to 2.7 to Done in Ansible-maintained Collections Documentation Dec 10, 2018
@ansible ansible locked and limited conversation to collaborators Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.6 This issue/PR affects Ansible v2.6 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. networking Network category new_contributor This PR is the first contribution by a new community member. python3 stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants