New Memset module to manage DNS zone records #40392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.6
mkrizek
removed
the
needs_triage
|
Added test records - working as expected! |
|
Works fine for me. |
|
Added and removed DNS records with this. Works exactly as expected |
resmo
reviewed
May 23, 2018
| - Manage DNS records in a Memset account. | ||
| options: | ||
| state: | ||
| required: true |
There was a problem hiding this comment.
not a blocker but the convention is to have present as default, please also consider this for your module.
There was a problem hiding this comment.
Sure, I can do that.
| # if we have any matches, delete them. | ||
| if records: | ||
| for zone_record in records: | ||
| if args['check_mode']: |
There was a problem hiding this comment.
not sure if this works, did you test check mode? shouldn't this be module.check_mode?
There was a problem hiding this comment.
I add it to the args here
|
@resmo unfortunately not, the API only supports a single record at a time so it's a case of a new task each time (when testing i've been using with_items). |
…e and add documentation for how to create multiple DNS records
|
counting 4 shipits. |
ansibot
added
shipit
|
Thanks! |
|
Works for me! |
gothicx
pushed a commit
to gothicx/ansible
that referenced
this pull request
Jun 9, 2018
jacum
pushed a commit
to jacum/ansible
that referenced
this pull request
Jun 26, 2018
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR provides a module to manage DNS zone records hosted at Memset .
ISSUE TYPE
COMPONENT NAME
ANSIBLE VERSION