Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os_server: Remove nova_client usage #40462

Merged
merged 1 commit into from
May 25, 2018
Merged

os_server: Remove nova_client usage #40462

merged 1 commit into from
May 25, 2018

Conversation

odyssey4me
Copy link
Contributor

SUMMARY

The os_server module uses the deprecated nova_client function, and
therefore ends up requiring python-novaclient installed.

In this patch we switch the ip detachment to make use of a shade
function, removing the need for python-novaclient.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

openstack os_server module

ANSIBLE VERSION
ansible 2.6.0 (devel 553cf4cdfc) last updated 2018/05/20 14:11:41 (GMT +100)
  config file = ~/.ansible.cfg
  configured module search path = [u'~/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = ~/code/ansible/lib/ansible
  executable location = ~/venvs/ansible-devel/bin/ansible
  python version = 2.7.10 (default, Oct  6 2017, 22:29:07) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.31)]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented May 20, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server.py:546:0: syntax-error positional argument follows keyword argument (<string>, line 546)

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "test/sanity/code-smell/docs-build.py", line 101, in <module>
    main()
  File "test/sanity/code-smell/docs-build.py", line 17, in main
    raise subprocess.CalledProcessError(sphinx.returncode, cmd, output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['make', 'singlehtmldocs']' returned non-zero exit status 2.

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server.py:546:0: SyntaxError: non-keyword arg after keyword arg

The test ansible-test sanity --test import --python 3.5 [explain] failed with 2 errors:

lib/ansible/modules/cloud/openstack/os_server.py:0:0: SyntaxError: positional argument follows keyword argument (os_server.py, line 546) (in /root/ansible/test/runner/.tox/minimal-py35/bin/importer.py:82)
lib/ansible/modules/cloud/openstack/os_server.py:546:33: SyntaxError: positional argument follows keyword argument

The test ansible-test sanity --test import --python 2.7 [explain] failed with 2 errors:

lib/ansible/modules/cloud/openstack/os_server.py:0:0: SyntaxError: non-keyword arg after keyword arg (os_server.py, line 546) (in /root/ansible/test/runner/.tox/minimal-py27/bin/importer.py:82)
lib/ansible/modules/cloud/openstack/os_server.py:546:0: SyntaxError: non-keyword arg after keyword arg

The test ansible-test sanity --test import --python 3.6 [explain] failed with 2 errors:

lib/ansible/modules/cloud/openstack/os_server.py:0:0: SyntaxError: positional argument follows keyword argument (os_server.py, line 546) (in /root/ansible/test/runner/.tox/minimal-py36/bin/importer.py:82)
lib/ansible/modules/cloud/openstack/os_server.py:546:33: SyntaxError: positional argument follows keyword argument

The test ansible-test sanity --test import --python 3.7 [explain] failed with 2 errors:

lib/ansible/modules/cloud/openstack/os_server.py:0:0: SyntaxError: positional argument follows keyword argument (os_server.py, line 546) (in /root/ansible/test/runner/.tox/minimal-py37/bin/importer.py:82)
lib/ansible/modules/cloud/openstack/os_server.py:546:33: SyntaxError: positional argument follows keyword argument

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/cloud/openstack/os_server.py:0:0: E401 Python SyntaxError while parsing module
test/sanity/validate-modules/ignore.txt:366:1: A102 Remove since "lib/ansible/modules/cloud/openstack/os_server.py" passes "E322" test
test/sanity/validate-modules/ignore.txt:367:1: A102 Remove since "lib/ansible/modules/cloud/openstack/os_server.py" passes "E324" test

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server.py:546:33: python-syntax-error positional argument follows keyword argument (<unknown>, line 546)

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented May 20, 2018

cc @dagnello @emonty @juliakreger @omgjlk @rcarrillocruz @Shrews @Thingee
click here for bot help

@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. openstack support:community This issue/PR relates to code supported by the Ansible community. labels May 20, 2018
@odyssey4me odyssey4me force-pushed the os-server-remove-nova_client branch 2 times, most recently from e52ba1c to e36fc33 Compare May 20, 2018 20:02
os_server: Remove nova_client usage
055d89c 
The os_server module uses the deprecated nova_client function, and
therefore ends up requiring python-novaclient installed. In this
patch we switch the ip detachment to make use of a shade function,
removing the need for python-novaclient.
@odyssey4me odyssey4me force-pushed the os-server-remove-nova_client branch from e36fc33 to 055d89c Compare May 20, 2018 20:08
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 20, 2018
@opendev-zuul
Copy link

opendev-zuul bot commented May 20, 2018

Build succeeded (third-party-check pipeline).

@opendev-zuul
Copy link

opendev-zuul bot commented May 20, 2018

Build succeeded (third-party-check pipeline).

emonty
emonty approved these changes May 20, 2018
View reviewed changes
Copy link
Contributor

@emonty emonty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label May 20, 2018
@odyssey4me odyssey4me mentioned this pull request May 20, 2018
Closed
@emonty emonty merged commit f53a29f into ansible:devel May 25, 2018
@odyssey4me odyssey4me deleted the os-server-remove-nova_client branch May 27, 2018 09:44
@odyssey4me odyssey4me mentioned this pull request May 27, 2018
Merged
gothicx pushed a commit to gothicx/ansible that referenced this pull request Jun 9, 2018
@gothicx
os_server: Remove nova_client usage (ansible#40462)
553d9c4 
The os_server module uses the deprecated nova_client function, and
therefore ends up requiring python-novaclient installed. In this
patch we switch the ip detachment to make use of a shade function,
removing the need for python-novaclient.
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
os_server: Remove nova_client usage (ansible#40462)
d85ec43 
The os_server module uses the deprecated nova_client function, and
therefore ends up requiring python-novaclient installed. In this
patch we switch the ip detachment to make use of a shade function,
removing the need for python-novaclient.
@ansible ansible locked and limited conversation to collaborators May 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emonty emonty emonty approved these changes

Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. openstack support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@odyssey4me @ansibot @emonty