Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os_project_access: clean up some things #40464

Merged
merged 2 commits into from
May 25, 2018
Merged

os_project_access: clean up some things #40464

merged 2 commits into from
May 25, 2018

Conversation

odyssey4me
Copy link
Contributor

SUMMARY

Remove an unused function and correct the documentation.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

openstack os_project_access module

ANSIBLE VERSION
ansible 2.6.0 (devel 553cf4cdfc) last updated 2018/05/20 14:11:41 (GMT +100)
  config file = ~/.ansible.cfg
  configured module search path = [u'~/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = ~/code/ansible/lib/ansible
  executable location = ~/venvs/ansible-devel/bin/ansible
  python version = 2.7.10 (default, Oct  6 2017, 22:29:07) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.31)]
ADDITIONAL INFORMATION

Jesse Pretorius added 2 commits May 20, 2018 22:08
os_project_access: correct example tasks
028b596 
The example task does not work. Fix it so that it does.
os_project_access: Remove unused function
c190a28 
The _get_allowed_projects function is not used anywhere,
so we can remove it and be free of nova_client for this
module.
@ansibot
Copy link
Contributor

ansibot commented May 20, 2018

cc @dagnello @emonty @ioggstream @juliakreger @omgjlk @rcarrillocruz @Shrews @Thingee
click here for bot help

@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. openstack support:community This issue/PR relates to code supported by the Ansible community. labels May 20, 2018
@odyssey4me odyssey4me changed the title os_project_access: remove nova client os_project_access: clean up some things May 20, 2018
@odyssey4me odyssey4me mentioned this pull request May 20, 2018
Closed
emonty
emonty reviewed May 20, 2018
View reviewed changes
Copy link
Contributor

@emonty emonty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label May 20, 2018
@opendev-zuul
Copy link

opendev-zuul bot commented May 20, 2018

Build succeeded (third-party-check pipeline).

@emonty emonty merged commit 1579178 into ansible:devel May 25, 2018
@odyssey4me odyssey4me deleted the os_project_access-remove-nova_client branch May 27, 2018 09:45
@odyssey4me odyssey4me mentioned this pull request May 27, 2018
Merged
gothicx pushed a commit to gothicx/ansible that referenced this pull request Jun 9, 2018
@gothicx
os_project_access: clean up some things (ansible#40464)
d77df0a 
* os_project_access: correct example tasks

The example task does not work. Fix it so that it does.

* os_project_access: Remove unused function

The _get_allowed_projects function is not used anywhere,
so we can remove it and be free of nova_client for this
module.
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
os_project_access: clean up some things (ansible#40464)
fba0f9f 
* os_project_access: correct example tasks

The example task does not work. Fix it so that it does.

* os_project_access: Remove unused function

The _get_allowed_projects function is not used anywhere,
so we can remove it and be free of nova_client for this
module.
@ansible ansible locked and limited conversation to collaborators May 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emonty emonty emonty approved these changes

Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. openstack support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@odyssey4me @ansibot @emonty