winrm: source user from options than remote_user #40467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.6
ansibot
removed
the
needs_revision
jborean93
force-pushed
the
winrm-user-source
branch
from
55bbaa2
to
0a3ffc0
Compare
jborean93
added a commit
to jborean93/ansible
that referenced
this pull request
May 21, 2018
* winrm: source user from options than remote_user * fixed up mock for kerberos import * Added changelog fragment * get hostname from option as well (cherry picked from commit 1ac180c)
|
Backport PR to stable-2.5 #40516 |
achinthagunasekara
pushed a commit
to achinthagunasekara/ansible
that referenced
this pull request
May 23, 2018
* winrm: source user from options than remote_user * fixed up mock for kerberos import * Added changelog fragment * get hostname from option as well
sivel
removed
the
needs_triage
jacum
pushed a commit
to jacum/ansible
that referenced
this pull request
Jun 26, 2018
* winrm: source user from options than remote_user * fixed up mock for kerberos import * Added changelog fragment * get hostname from option as well
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
* winrm: source user from options than remote_user * fixed up mock for kerberos import * Added changelog fragment * get hostname from option as well
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When sourcing the username we currently get it from the play context. Because
ansible_ssh_useris a global fallback it overridesansible_usereven if that is set at a higher var level. This also fixes the issue whereansible_winrm_userdoes not work at all.Fixes #39844
ISSUE TYPE
COMPONENT NAME
winrm
ANSIBLE VERSION