win_environment: Added explicit check for null, empty string with state=present #40468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.6
ansibot
added
core_review
|
Looks good to me, thanks for fixing this up. |
ansibot
removed
the
needs_triage
jborean93
added a commit
to jborean93/ansible
that referenced
this pull request
May 21, 2018
…te=present (ansible#40468) * win_environment: Added explicit check for null, empty string with state=present * Added changelog fragment (cherry picked from commit db19583)
|
Backport PR for stable-2.5 #40508 |
achinthagunasekara
pushed a commit
to achinthagunasekara/ansible
that referenced
this pull request
May 23, 2018
…te=present (ansible#40468) * win_environment: Added explicit check for null, empty string with state=present * Added changelog fragment
jacum
pushed a commit
to jacum/ansible
that referenced
this pull request
Jun 26, 2018
…te=present (ansible#40468) * win_environment: Added explicit check for null, empty string with state=present * Added changelog fragment
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
…te=present (ansible#40468) * win_environment: Added explicit check for null, empty string with state=present * Added changelog fragment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When setting an environment value as null or an empty string, WIndows will actually delete the env key as it isn't valid in Windows. This change adds a failure message as
state: presentshould not be deleting env entries.Fixes #40450
ISSUE TYPE
COMPONENT NAME
win_environment
ANSIBLE VERSION