Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define module for managing the NetApp E-Series iSCSI target #40632

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Define module for managing the NetApp E-Series iSCSI target #40632

merged 1 commit into from
Aug 28, 2018

Conversation

lmprice
Copy link
Contributor

@lmprice lmprice commented May 23, 2018

Create a new module for managing E-Series iSCSI targets.

SUMMARY

Develop a new module for managing the iSCSI target settings for E-Series storage-systems.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

netapp_e_iscsi_target

ANSIBLE VERSION
ansible 2.6.0 (detached HEAD ce8c336d52) last updated 2018/04/18 11:23:03 (GMT -500)
  config file = None
  configured module search path = [u'/home/lorenp/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/lorenp/ansible/lib/ansible
  executable location = /home/lorenp/ansible/bin/ansible
  python version = 2.7.12 (default, Dec  4 2017, 14:50:18) [GCC 5.4.0 20160609]
ADDITIONAL INFORMATION
changed: [testhost] => {"alias": "abc", "changed": true, "iqn": "iqn.1992-08.com.netapp:2804.600a098000a096d2000000005a0e8f45", "msg": "The interface settings have been updated."}

@ansibot
Copy link
Contributor

ansibot commented May 23, 2018

cc @amit0701 @broncofan @carchi8py @hulquest @schmots1
click here for bot help

@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels May 23, 2018
@ansibot
Copy link
Contributor

ansibot commented May 23, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_iscsi_target.py:0:0: E325 argument_spec for "validate_certs" defines type="bool" but documentation does not

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels May 23, 2018
@ansibot
Copy link
Contributor

ansibot commented May 23, 2018

cc @mattclay
click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 23, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label May 24, 2018
@ansibot
Copy link
Contributor

ansibot commented May 24, 2018

cc @ndswartz
click here for bot help

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 1, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 4, 2018
@ansibot
Copy link
Contributor

ansibot commented Jun 4, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_iscsi_target.py:0:0: E307 version_added should be 2.7. Currently 2.6

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 4, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jun 4, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 4, 2018
ndswartz
ndswartz approved these changes Jun 4, 2018
View reviewed changes
Copy link
Contributor

@ndswartz ndswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 4, 2018
gundalow
gundalow reviewed Aug 28, 2018
View reviewed changes
lib/ansible/utils/module_docs_fragments/netapp.py Outdated
@@ -121,24 +121,31 @@ class ModuleDocFragment(object):
api_username:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change needs removing from this PR (as it's been done in another PR which has since been merged)

Also you need to rebase to resolve the merge conflict https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html

gundalow
gundalow approved these changes Aug 28, 2018
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module itself looks OK, please just remove the docs_fragment and ignore.txt files from this PR and then rebase your PR I think this change needs removing from this PR (as it's been done in another PR which has since been merged)

Also you need to rebase to resolve the merge conflict https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed shipit This PR is ready to be merged by Core labels Aug 28, 2018
@lmprice
Define module for NetApp E-Series iSCSI targets
5b62ab7 
Create a new module for managing E-Series iSCSI targets.
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 28, 2018
@gundalow gundalow merged commit 70fd1ec into ansible:devel Aug 28, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

@ndswartz ndswartz ndswartz approved these changes

Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. netapp new_module This PR includes a new module. new_plugin This PR includes a new plugin. storage support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lmprice @ansibot @gundalow @ndswartz @jborean93