Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os_server: Remove nova_client usage #40765

Merged
merged 1 commit into from
Jun 7, 2018
Merged

os_server: Remove nova_client usage #40765

merged 1 commit into from
Jun 7, 2018

Conversation

odyssey4me
Copy link
Contributor

SUMMARY

The os_server module uses the deprecated nova_client function, and
therefore ends up requiring python-novaclient installed. In this
patch we switch the ip detachment to make use of a shade function,
removing the need for python-novaclient.

(cherry picked from commit 055d89c)

Backports #40462

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

openstack os_server module

ANSIBLE VERSION
ansible 2.5.3 (backport/2.5/40462 09e6cd53c8) last updated 2018/05/27 10:54:20 (GMT +100)
  config file = ~/.ansible.cfg
  configured module search path = [u'~/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = ~/code/ansible/lib/ansible
  executable location = ~/venvs/ansible-2.5/bin/ansible
  python version = 2.7.10 (default, Oct  6 2017, 22:29:07) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.31)]
ADDITIONAL INFORMATION

os_server: Remove nova_client usage
09e6cd5 
The os_server module uses the deprecated nova_client function, and
therefore ends up requiring python-novaclient installed. In this
patch we switch the ip detachment to make use of a shade function,
removing the need for python-novaclient.

(cherry picked from commit 055d89c)
@ansibot
Copy link
Contributor

ansibot commented May 27, 2018

cc @dagnello @emonty @juliakreger @omgjlk @rcarrillocruz @Shrews @Thingee
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. openstack support:community This issue/PR relates to code supported by the Ansible community. labels May 27, 2018
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label May 28, 2018
@emonty
Copy link
Contributor

emonty commented May 29, 2018

shipit

1 similar comment
@Shrews
Copy link
Contributor

Shrews commented May 30, 2018

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 30, 2018
@nitzmahone nitzmahone merged commit d525d7c into ansible:stable-2.5 Jun 7, 2018
@odyssey4me odyssey4me deleted the backport/2.5/40462 branch June 8, 2018 07:40
@ansible ansible locked and limited conversation to collaborators Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. openstack shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@odyssey4me @ansibot @emonty @Shrews @Akasurde @nitzmahone