Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenabling container instance tests #40780

Merged
merged 1 commit into from May 29, 2018
Merged

Reenabling container instance tests #40780

merged 1 commit into from May 29, 2018

Conversation

zikalino
Copy link
Contributor

SUMMARY

I have made significant changes to test, upgraded mgmt. module version and fixed issues with the module. So I expect this test to be stable now

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_containerinstance

ANSIBLE VERSION

2.5

ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 azure bug This issue/PR relates to a bug. cloud needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels May 28, 2018
@zikalino zikalino closed this May 28, 2018
@zikalino zikalino reopened this May 28, 2018
@ansibleazurebot ansibleazurebot mentioned this pull request May 29, 2018
Closed
@zikalino zikalino requested a review from mattclay May 29, 2018 02:33
@zikalino
Copy link
Contributor Author

@mattclay i think this one is ready to be reenabled, could you approve, so i will merge?
(the fix was actually made in a separate pr, but i haven't removed unstable )

@yungezz yungezz merged commit 726d7fe into ansible:devel May 29, 2018
@zikalino zikalino deleted the removing-unstable-from-container-instance branch May 29, 2018 07:14
@zikalino zikalino restored the removing-unstable-from-container-instance branch May 29, 2018 07:14
@mattclay mattclay mentioned this pull request May 30, 2018
Closed
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label May 31, 2018
@yuwzho yuwzho mentioned this pull request Jun 4, 2018
Closed
gothicx pushed a commit to gothicx/ansible that referenced this pull request Jun 9, 2018
@gothicx
removing unstable from container instance (ansible#40780)
19f8a54
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
removing unstable from container instance (ansible#40780)
1f6827b
@yungezz yungezz deleted the removing-unstable-from-container-instance branch August 31, 2018 01:54
@ansible ansible locked and limited conversation to collaborators May 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yungezz yungezz yungezz approved these changes

@mattclay mattclay Awaiting requested review from mattclay

Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 azure bug This issue/PR relates to a bug. cloud support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zikalino @yungezz @mkrizek @ansibot