Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VC scaleway #40791

Merged
merged 1 commit into from
Jun 11, 2018
Merged

Remove VC scaleway #40791

merged 1 commit into from
Jun 11, 2018

Conversation

remyleone
Copy link
Contributor

SUMMARY

The VC product line is going to be replaced with the START1 product line.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • scaleway_compute.py
ANSIBLE VERSION
ansible 2.7.0dev0 (remove_vc 4a2509d751) last updated 2018/05/28 14:35:23 (GMT +200)
  config file = None
  configured module search path = [u'/Users/sieben/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/sieben/workspace/ansible/lib/ansible
  executable location = /Users/sieben/workspace/ansible/bin/ansible
  python version = 2.7.15 (default, May  1 2018, 16:44:08) [GCC 4.2.1 Compatible Apple LLVM 9.1.0 (clang-902.0.39.1)]
ADDITIONAL INFORMATION

You should be able to test with the following command:

$ python ./bin/ansible-playbook -vvvvv -i /dev/null ./test/legacy/scaleway_compute.yml

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels May 28, 2018
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Jun 1, 2018
@s-hertel s-hertel requested a review from maxamillion June 1, 2018 17:44
@maxamillion
Copy link
Contributor

shipit

@maxamillion
Copy link
Contributor

@sieben - is this something that needs to be backported to Ansible 2.6? (devel is 2.7 now)

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 2, 2018
@remyleone
Copy link
Contributor Author

remyleone commented Jun 2, 2018 via email

@maxamillion
Copy link
Contributor

@sieben make a cherry-pick PR for the stable-2.6 branch once this merges into devel, I'll approve and merge it.

@remyleone
Copy link
Contributor Author

remyleone commented Jun 4, 2018 via email

@remyleone
Copy link
Contributor Author

@maxamillion Could you merge it ?

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. shipit This PR is ready to be merged by Core and removed shipit This PR is ready to be merged by Core needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jun 6, 2018
@maxamillion maxamillion merged commit 007127e into ansible:devel Jun 11, 2018
maxamillion added a commit that referenced this pull request Jun 11, 2018
@maxamillion
Copy link
Contributor

@sieben sorry, that was on me

maxamillion added a commit that referenced this pull request Jun 11, 2018
maxamillion added a commit that referenced this pull request Jun 11, 2018
maxamillion added a commit that referenced this pull request Jun 11, 2018
@remyleone remyleone deleted the remove_vc branch June 15, 2018 15:03
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@ansible ansible locked and limited conversation to collaborators Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants