ec2_lc: fix state doc matching arg_spec #40792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
s-hertel
removed
the
needs_triage
s-hertel
reviewed
May 30, 2018
| @@ -389,6 +389,7 @@ | |||
|
|
|||
|
|
|||
| def create_block_device_meta(module, volume): | |||
| # TODO seems unused, remove? | |||
There was a problem hiding this comment.
Yeah, +1 to remove that. It looks like it was added 4 years ago and wasn't even used then, and handling the IOPS ratio would be a new feature to the module (they were referring to ...ratio has been increased from 10:1 to 30:1 on https://aws.amazon.com/about-aws/whats-new/2013/10/09/ebs-provisioned-iops-maximum-iops-gb-ratio-increased-to-30-1/). IOPS is specified as a value in volume and relevant values for the module are ranges from 100-20000 IOPS for io1 volumes and 100-10000 IOPS for gp2 volumes.
jacum
pushed a commit
to jacum/ansible
that referenced
this pull request
Jun 26, 2018
* ec2_lc: fix state doc matching arg_spec * Remove unused variable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
fixes doc of ec2_lc to match arg spec, see https://github.com/ansible/ansible/pull/40792/files#diff-227ec68592e782f403eac767c026e73bR605
ISSUE TYPE
COMPONENT NAME
ec2_lc
ANSIBLE VERSION
ADDITIONAL INFORMATION