Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #34992 - azure_rm_networkinterface and azure_rm_virtualmachine inconsistent "location" param #40802

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Fixes #34992 - azure_rm_networkinterface and azure_rm_virtualmachine inconsistent "location" param #40802

merged 1 commit into from
Jun 4, 2018

Conversation

yuwzho
Copy link
Contributor

@yuwzho yuwzho commented May 28, 2018 •
edited

SUMMARY

Fixes #34992 - azure_rm_networkinterface and azure_rm_virtualmachine inconsistent "location" param

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ANSIBLE VERSION
2.5.2
ADDITIONAL INFORMATION

Try this PR's change by installing ansible role via git

ansible-galaxy install git+https://github.com/Azure/azure_preview_modules.git,yuwzho-location

And add a role definition in the playbook

---
- name: XXXXXXXXXXX
  hosts: localhost
  connection: local
  roles:
  - azure_preview_modules
  tasks:

@ansibot
Copy link
Contributor

ansibot commented May 28, 2018

cc @haroldwongms @nitzmahone @trstringer @xscript @zikalino
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 azure bug This issue/PR relates to a bug. cloud committer_review In order to be merged, this PR must follow the certified review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:certified This issue/PR relates to certified code. labels May 28, 2018
@ansibleazurebot ansibleazurebot mentioned this pull request May 29, 2018
Closed
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Jun 1, 2018
@yungezz
Copy link
Contributor

yungezz commented Jun 4, 2018

add a test? or update an existing one to cover this?

@yuwzho
Copy link
Contributor Author

yuwzho commented Jun 4, 2018

@yungezz no, since different subscription has different support location to create resources, I cannot create a resource in test with specific location.

@yungezz
Copy link
Contributor

yungezz commented Jun 4, 2018

@yuwzho confirmed manually tested the change.

@yungezz yungezz merged commit e6e08a0 into ansible:devel Jun 4, 2018
@yuwzho yuwzho deleted the yuwzho-location branch June 4, 2018 05:49
yuwzho added a commit to VSChina/ansible that referenced this pull request Jun 7, 2018
@yuwzho
normalize the resource location (ansible#40802)
cc78a15 
(cherry picked from commit e6e08a0)
mattclay pushed a commit that referenced this pull request Jun 7, 2018
@yuwzho @mattclay
normalize the resource location (#40802)
96929ac 
(cherry picked from commit e6e08a0)
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@yuwzho
normalize the resource location (ansible#40802)
74b1fa8
@ansible ansible locked and limited conversation to collaborators Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yungezz yungezz yungezz approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 azure bug This issue/PR relates to a bug. cloud committer_review In order to be merged, this PR must follow the certified review workflow. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:certified This issue/PR relates to certified code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

azure_rm_networkinterface and azure_rm_virtualmachine inconsistent "location" param
4 participants
@yuwzho @ansibot @yungezz @mkrizek