Use low-level package objects in the apt module to check installed state

[jimi-c]

Packages which are half-installed are not adequately represented by
the .is_installed field of the apt.package.Package object. By using the
lower-level apt_pkg.Package object (which provides the .current_state
field), we can check for a partially-installed state more accurately.

Fixes #3421

[mpdehaan]

Code looks good to me.

Just would want to make sure here it's supported consistently on older Debian systems, Ubuntu 12.04 and new Ubuntu in case it's not part of the main "API". Thoughts?

[jimi-c]

This was tested on 12.04, but I can build a 10.04 box to test on as well. The above is still part of the API and appears to have not changed in a while (it was the higher level Package object that changed around 0.8.x).

[mpdehaan]

10x is pretty old and/or I've never head anyone running that.

I'm more interested in possible Debian combinations people may be running and also rather new Ubuntues (Ubuntui?)

Needs to work with any possible Debians people are already using.

[srgvg]

FYI 10.04 is a LTS release which still is supported by Canonical atm. We for one are still running boxes with that version.

[mpdehaan]

Ok. We still need to test on Debians and new Ubuntu alike.

Can you please help test on your platform Serge?

On Sun, Sep 15, 2013 at 1:37 PM, Serge van Ginderachter <
notifications@github.com> wrote:

FYI 10.04 is a LTS release which still is supported by Canonical atm. We
for one are still running boxes with that version.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/4091#issuecomment-24475975
.

[srgvg]

Sure; as per #3421 (comment) I already tested the patch, but I'll make sure I target some 10.04 boxes; not sure if I did that.

[srgvg]

checked ubuntu

• 10.04
• 10.10
• and previously 12.04

with ansible 1.3 (issue_3421_apt_pkg_iU 0d408ff) last updated 2013/09/12 10:43:46 (GMT +200)

• update cache
• install/remove packages
• (re)install half installed iU packages

no problem whatsoever, so +1

[jimi-c]

Thanks @sergevanginderachter!