-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix stack_model and stack_serialnum case matching #40928
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Account for upper/lower case match occurrences of "[Nn]umber" and "[Ss]erial" Model Number : WS-C3850-12X48U System Serial Number : <removed>
ansibot
added
affects_2.7
This issue/PR affects Ansible v2.7
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
module
This issue/PR relates to a module.
needs_triage
Needs a first human triage before being processed.
networking
Network category
new_contributor
This PR is the first contribution by a new community member.
support:network
This issue/PR relates to code supported by the Ansible Network Team.
labels
May 31, 2018
mkrizek
removed
the
needs_triage
Needs a first human triage before being processed.
label
Jun 1, 2018
Qalthos
pushed a commit
to Qalthos/ansible
that referenced
this pull request
Jun 6, 2018
Account for upper/lower case match occurrences of "[Nn]umber" and "[Ss]erial" Model Number : WS-C3850-12X48U System Serial Number : <removed> (cherry picked from commit 12d2211)
Qalthos
pushed a commit
to Qalthos/ansible
that referenced
this pull request
Jun 6, 2018
Account for upper/lower case match occurrences of "[Nn]umber" and "[Ss]erial" Model Number : WS-C3850-12X48U System Serial Number : <removed> (cherry picked from commit 12d2211)
mattclay
pushed a commit
that referenced
this pull request
Jun 7, 2018
Account for upper/lower case match occurrences of "[Nn]umber" and "[Ss]erial" Model Number : WS-C3850-12X48U System Serial Number : <removed> (cherry picked from commit 12d2211)
nitzmahone
pushed a commit
that referenced
this pull request
Jun 8, 2018
* Do not gather mem facts if command invalid (#40820) * Do not gather mem facts if command invalid In some firmwares, 'show memory statistics' fail, thus do not populate mem if we got a failure after running that command. * Fix pep8 * Warn if got error when running 'sh memory statistics' * Fix pep8 (cherry picked from commit 669949e) * Update ios_facts.py (#40928) Account for upper/lower case match occurrences of "[Nn]umber" and "[Ss]erial" Model Number : WS-C3850-12X48U System Serial Number : <removed> (cherry picked from commit 12d2211) * Expand ios password prompt regex (#41131) (cherry picked from commit 49fddb6)
jacum
pushed a commit
to jacum/ansible
that referenced
this pull request
Jun 26, 2018
Account for upper/lower case match occurrences of "[Nn]umber" and "[Ss]erial" Model Number : WS-C3850-12X48U System Serial Number : <removed>
Is this pushed into the 2.6 release ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.7
This issue/PR affects Ansible v2.7
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
module
This issue/PR relates to a module.
networking
Network category
new_contributor
This PR is the first contribution by a new community member.
support:network
This issue/PR relates to code supported by the Ansible Network Team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Account for upper/lower case match occurrences of "[Nn]umber" and "[Ss]erial"
Model Number : WS-C3850-12X48U
System Serial Number :
SUMMARY
For stack type switches, string matching for "Model number" and "serial number" need to account for upper and lower case. "Number" or "number", and "Serial" or "serial" are all valid depending on switch model and/or IOS version.
ISSUE TYPE
COMPONENT NAME
ios_facts
ANSIBLE VERSION
ADDITIONAL INFORMATION
BEFORE CHANGES:
AFTER CHANGES: All three scenarios of 3750X-48, 3850-48U and 3850-12X48U return models and serial #s as expected.