Fix: wildcard excludes in unarchive with tar archives

[sijis]

SUMMARY

Fixes an issue where the exclude option is used and one of the entries contains a wildcard, the unarchive module does not exclude files matching those wildcards as expected.

Fixes #37842, #22947
Related #40120

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

unarchive

ANSIBLE VERSION

ansible 2.7.0.dev0 (fix/unarchive/exclude_tar d8ef19b0c3) last updated 2018/05/31 02:04:19 (GMT -500)
  config file = None
  configured module search path = ['/home/saviles/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/saviles/data/git/github/ansible/lib/ansible
  executable location = /home/saviles/data/git/github/ansible/bin/ansible
  python version = 3.6.5 (default, Mar 29 2018, 18:20:46) [GCC 8.0.1 20180317 (Red Hat 8.0.1-0.19)]

ADDITIONAL INFORMATION

Playbook used to test

- hosts: localhost
  vars:
    issue: 37842
    src_dir: "files/{{ issue }}"
    dst_dir: "/tmp/{{ issue }}"
  tasks:
    - name: Create directory
      file:
        state: directory
        path: "{{item}}"
      with_items:
        - "{{src_dir}}"
        - "{{dst_dir}}"

    - name: Create files
      shell: "touch {{src_dir}}/{include,exclude}-{0..9}.txt"

    - name: Create archive file
      archive:
        format: "tar"
        path: "{{src_dir}}/*"
        dest: "{{src_dir}}.tar"

    - name: Unpack zip file
      unarchive:
        src: "{{src_dir}}.tar"
        dest: "{{dst_dir}}"
        # remote_src: yes
        exclude:
          - "exclude-*.txt"
      register: unzipped

    - name: Debug unzipped
      debug:
        msg: "{{unzipped}}"
        # verbosity: 2

Before fix

$ ls /tmp/37842/
exclude-0.txt  exclude-2.txt  exclude-4.txt  exclude-6.txt  exclude-8.txt  include-0.txt  include-2.txt  include-4.txt  include-6.txt  include-8.txt
exclude-1.txt  exclude-3.txt  exclude-5.txt  exclude-7.txt  exclude-9.txt  include-1.txt  include-3.txt  include-5.txt  include-7.txt  include-9.txt

After fix

$ ls /tmp/37842/
include-0.txt  include-1.txt  include-2.txt  include-3.txt  include-4.txt  include-5.txt  include-6.txt  include-7.txt  include-8.txt  include-9.txt

I still need to include integration tests.

[ansibot]

cc @pileofrogs
click here for bot help

[mattclay]

CI failure in integration tests: https://app.shippable.com/github/ansible/ansible/runs/69413/38/tests

[ansibot]

The test ansible-test sanity --test no-tests-as-filters [explain] failed with 1 error:

test/integration/targets/unarchive/tasks/main.yml:247:16: use `item.stdout is search` instead of `item.stdout | search`

click here for bot help

[sijis]

Rebased.