Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nxos output truncated issue and nxos_banner issue #40962

Merged
merged 4 commits into from
Jun 7, 2018
Merged

fix nxos output truncated issue and nxos_banner issue #40962

merged 4 commits into from
Jun 7, 2018

Conversation

trishnaguha
Copy link
Member

@trishnaguha trishnaguha commented May 31, 2018 •
edited

SUMMARY

fix nxos output truncated issue #40683
Related to #40960
cherry-pick #40962

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/terminal/nxos.py
modules/network/nxos/nxos_banner.py

@trishnaguha
fix nxos output truncated issue
b753167 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@ansibot
Copy link
Contributor

ansibot commented May 31, 2018

cc @Qalthos @ganeshrn @gdpak @gundalow @privateip @rcarrillocruz
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 31, 2018
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label May 31, 2018
@trishnaguha trishnaguha added this to To Do in 2.5.x blocker list via automation May 31, 2018
@trishnaguha trishnaguha force-pushed the stable-2.5 branch 2 times, most recently from e3d7da0 to 9190588 Compare May 31, 2018 16:22
@trishnaguha
add changelog
5752175 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
saichint and others added 2 commits June 7, 2018 10:25
@trishnaguha
fix nxos_banner issue (ansible#41026)
311331d 
(cherry picked from commit b6afb77)
@trishnaguha
add changelog for nxos_banner fix
e21ada6 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha trishnaguha changed the title fix nxos output truncated issue fix nxos output truncated issue and nxos_banner issue Jun 7, 2018
@ansibot
Copy link
Contributor

ansibot commented Jun 7, 2018

cc @mikewiebe @rahushen
click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Jun 7, 2018
@nitzmahone nitzmahone merged commit ebc36ee into ansible:stable-2.5 Jun 7, 2018
@trishnaguha trishnaguha deleted the stable-2.5 branch June 7, 2018 17:16
@nitzmahone nitzmahone moved this from To Do to Done in 2.5.x blocker list Jun 8, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@nitzmahone nitzmahone

Labels
affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
No open projects
2.5.x blocker list
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@trishnaguha @ansibot @dagwieers @nitzmahone