Define a module for managing E-Series top-level settings #41010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
|
The test |
ansibot
added
ci_verified
mkrizek
removed
the
needs_triage
ansibot
added
core_review
ansibot
added
shipit
ansibot
added
netapp
storage
needs_revision
ansibot
added
shipit
gundalow
reviewed
Aug 28, 2018
| @@ -121,24 +121,31 @@ class ModuleDocFragment(object): | |||
| api_username: | |||
| required: true | |||
| description: | |||
| - The username to authenticate with the SANtricity WebServices Proxy or embedded REST API. | |||
| - The username to authenticate with the SANtricity Web Services Proxy or Embedded Web Services API. | |||
There was a problem hiding this comment.
I think this change needs removing from this PR (as it's been done in another PR which has since been merged)
Also you need to rebase to resolve the merge conflict https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
gundalow
reviewed
Aug 28, 2018
| @@ -1207,7 +1207,6 @@ lib/ansible/modules/storage/netapp/na_cdot_volume.py E322 | |||
| lib/ansible/modules/storage/netapp/na_cdot_volume.py E324 | |||
| lib/ansible/modules/storage/netapp/na_cdot_volume.py E325 | |||
| lib/ansible/modules/storage/netapp/netapp_e_amg.py E322 | |||
There was a problem hiding this comment.
I think this change needs removing from this PR (as it's been done in another PR which has since been merged)
Also you need to rebase to resolve the merge conflict https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
gundalow
approved these changes
Aug 28, 2018
There was a problem hiding this comment.
Module itself looks OK, please just remove the docs_fragment and ignore.txt files from this PR and then rebase your PR I think this change needs removing from this PR (as it's been done in another PR which has since been merged)
Also you need to rebase to resolve the merge conflict https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
ansibot
added
needs_rebase
There are multiple settings that are defined at a global level for E-Series systems, but don't necessarily fit with anything else. This module is intended to provide a place to encapsulate those.
ansibot
added
core_review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
There are multiple settings that are defined at a global level for
E-Series systems, but don't necessarily fit with anything else. This
module is intended to provide a place to encapsulate those.
ISSUE TYPE
New Module Pull Request
COMPONENT NAME
netapp_e_global
ANSIBLE VERSION
ADDITIONAL INFORMATION