Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subversion: Only fire changed when content has changed #41036

Merged
merged 4 commits into from
Sep 4, 2018
Merged

Subversion: Only fire changed when content has changed #41036

merged 4 commits into from
Sep 4, 2018

Conversation

mintsoft
Copy link
Contributor

@mintsoft mintsoft commented Jun 1, 2018

SUMMARY

Previously if you checkout only a branch of part of a subversion repostitory
and another part of the repository is updated then the change handler would
fire even if the branch/subdirectory that we're interested in hasn't changed.

This now parses the output to only indicate that there has been a change when
the actual content is changed.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

Subversion

ANSIBLE VERSION
ansible 2.2.1.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = Default w/o overrides

Also tested under

ansible 2.3.1.0
  config file =
  configured module search path = Default w/o overrides
  python version = 2.7.9 (default, Jun 29 2016, 13:08:31) [GCC 4.9.2]
ADDITIONAL INFORMATION

@mintsoft
Previously when checking out a subdirectory, if changes are made in the
c723abf 
repository that aren't present in the subdirectory (i.e. in a different
branch or similiar) then the changes handler still kicks in even though
the content of this working copy hasn't necessarily changed. Now we parse
the output of svn update and fire if anything changes at all.
@mintsoft
Previously when checking out a subdirectory, if changes are made in the
aee5268 
repository that aren't present in the subdirectory (i.e. in a different
branch or similiar) then the changes handler still kicks in even though
the content of this working copy hasn't necessarily changed. Now we parse
the output of svn update and svn switch, firing if anything changes at all.
@ansibot
Copy link
Contributor

ansibot commented Jun 1, 2018

cc @dsummersl
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 1, 2018
@ansibot
Copy link
Contributor

ansibot commented Jun 1, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/source_control/subversion.py:191:15: singleton-comparison Comparison to None should be 'expr is None'

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/source_control/subversion.py:191:47: E711 comparison to None should be 'if cond is None:'

The test ansible-test sanity --test shebang [explain] failed with 1 error:

lib/ansible/modules/source_control/subversion.py:0:0: module should not be executable

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 1, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 1, 2018
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Jun 1, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 9, 2018
@mintsoft mintsoft closed this Jul 17, 2018
@mintsoft mintsoft reopened this Jul 17, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 17, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 25, 2018
@mintsoft mintsoft closed this Aug 6, 2018
@mintsoft mintsoft reopened this Aug 6, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 6, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 14, 2018
@mintsoft
Copy link
Contributor Author

@dsummersl is there anything particular I can do to get this more attention? It should be ready to go :)

@dsummersl
Copy link
Contributor

@mintsoft I was able to test this and confirm that this fixes the issue; thanks! Also verified that ansible-test cases are passing now.

shipit

@mintsoft
Copy link
Contributor Author

mintsoft commented Sep 2, 2018

Hmm is ansibot supposed to have merged the commit in by now @dsummersl ?

@dsummersl
Copy link
Contributor

Hmm, yes. I see a couple things: this PR is labelled with stale_ci, and when I mouse over that tag it says "Close and reopen this PR to get it retested". It also is labelled with core_review which https://docs.ansible.com/ansible/latest/community/development_process.html#workflow suggests that this PR will have to wait for a core member for the final go ahead - I guess my shipit doesn't count here :(

I'd suggest getting that first stale_ci to go away.

@mintsoft mintsoft closed this Sep 3, 2018
@mintsoft mintsoft reopened this Sep 3, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 3, 2018
@mintsoft
Copy link
Contributor Author

mintsoft commented Sep 3, 2018

@dsummersl Ahh I see, I'll have to see if I can entice a core team member to have a look.

Maybe @maxamillion could do me the favour 😉

@maxamillion
Copy link
Contributor

rebuild_merge

@ansibot ansibot merged commit 41db45a into ansible:devel Sep 4, 2018
@mintsoft mintsoft deleted the mintsoft/subversion-change-on-changes-only branch September 5, 2018 19:15
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mintsoft @ansibot @dsummersl @maxamillion @s-hertel