Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openstack: Correct fail_json call in module_utils #41064

Merged
merged 1 commit into from
Jun 4, 2018
Merged

openstack: Correct fail_json call in module_utils #41064

merged 1 commit into from
Jun 4, 2018

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Jun 3, 2018

SUMMARY

Fixes: #40925

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/openstack.py

ANSIBLE VERSION
2.7devel

@Akasurde
openstack: Correct fail_json call in module_utils
af89c29 
Fixes: ansible#40925

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde mentioned this pull request Jun 3, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Jun 3, 2018

cc @dagnello @emonty @juliakreger @omgjlk @rcarrillocruz @Shrews @Thingee
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud needs_triage Needs a first human triage before being processed. openstack support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 3, 2018
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Jun 3, 2018
@opendev-zuul
Copy link

opendev-zuul bot commented Jun 3, 2018

Build succeeded (third-party-check pipeline).

@Akasurde Akasurde requested a review from mkrizek June 4, 2018 07:15
@mkrizek mkrizek merged commit 13c7d14 into ansible:devel Jun 4, 2018
@Akasurde Akasurde deleted the openstack_fail_json branch June 4, 2018 08:27
@Akasurde
Copy link
Member Author

Akasurde commented Jun 4, 2018

@mkrizek Thanks for the review.

jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@Akasurde
openstack: Correct fail_json call in module_utils (ansible#41064)
052c74d 
Fixes: ansible#40925

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@carstenkoester carstenkoester mentioned this pull request Jul 17, 2018
Closed
@ansible ansible locked and limited conversation to collaborators Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkrizek mkrizek mkrizek approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud openstack support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fail_json method called incorrectly in openstack.py
3 participants
@Akasurde @ansibot @mkrizek