Warn when cond is used on meta tasks that don't support them #41126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
Akasurde
removed
the
needs_triage
|
we shoudl actually warn on all keywords that are ignored #27897, but this is a good start |
bcoca
approved these changes
Jun 5, 2018
jacum
pushed a commit
to jacum/ansible
that referenced
this pull request
Jun 26, 2018
mkrizek
added a commit
to mkrizek/ansible
that referenced
this pull request
Nov 6, 2018
(Partially cherry picked from commit 5f7ffd3)
mattclay
pushed a commit
that referenced
this pull request
Nov 6, 2018
openstack-gerrit
pushed a commit
to openstack/kolla-ansible
that referenced
this pull request
May 14, 2019
The flush_handlers clause doesn't honour conditional clauses. Instead, it prints a warning and runs anyway: [WARNING]: flush_handlers task does not support when conditional See: ansible/ansible#41126 TrivialFix Change-Id: Iaf70c2e932ae6dfb723bdb2ba658acdbfe74ebe2
openstack-gerrit
pushed a commit
to openstack/openstack
that referenced
this pull request
May 14, 2019
* Update kolla-ansible from branch 'master'
- Merge "Ansible flush_handlers ignores conditional clauses"
- Ansible flush_handlers ignores conditional clauses
The flush_handlers clause doesn't honour conditional clauses.
Instead, it prints a warning and runs anyway:
[WARNING]: flush_handlers task does not support when conditional
See: ansible/ansible#41126
TrivialFix
Change-Id: Iaf70c2e932ae6dfb723bdb2ba658acdbfe74ebe2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #27565
ISSUE TYPE
COMPONENT NAME
lib/ansible/plugins/strategy/init.py
ANSIBLE VERSION
ADDITIONAL INFORMATION