bump version of 'vcenter-test-container' to '1.3.0' (govmomi v0.18.0) #41151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
Akasurde
removed
the
needs_triage
mattclay
requested changes
Jun 6, 2018
| @@ -48,4 +48,4 @@ | |||
| - name: make sure no changes were made | |||
| assert: | |||
| that: | |||
| - "poweroff_d1_c1_f0.results|map(attribute='changed')|unique|list == [False]" | |||
| - "poweroff_d1_c1_f0.results|map(attribute='changed')|unique|list == [True]" | |||
There was a problem hiding this comment.
Why is the task name make sure no changes were made when we're asserting that changes were made?
There was a problem hiding this comment.
In previous VCSIM version, vms were spawned in "poweredoff" state, and running this PB would poweroff them. But now with latest changes in VCSIM, vms are spawned in "PoweredOn" mode so running the PB would make "changed" as True. I agree to change task name as it is confusing.
There was a problem hiding this comment.
@Akasurde Thanks for the explanation.
@dericcrago This PR should be ready to merge once the task names are fixed.
ansibot
added
the
needs_revision
mattclay
approved these changes
Jun 6, 2018
jacum
pushed a commit
to jacum/ansible
that referenced
this pull request
Jun 26, 2018
…ansible#41151) * leave vmware_guest_powerstate tests enabled, but revert changes from: 66743f3 * leave VM poweroff tests enabled, but revert changes from: 87d6bda * bumped 'vcenter-test-container' version to '1.3.0' * updated test task names based on PR feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
updates 'vcenter-test-container' to '1.3.0' which has the latest tagged version of 'govmomi' (vcsim) 'v0.18.0'.
ISSUE TYPE
COMPONENT NAME
ANSIBLE VERSION
ADDITIONAL INFORMATION
This required updating a couple of the vmware_guest* module tests (needed to revert the
Falseback toTruefrom ansible:87d6bdaf & ansible:66743f33)