Define NetApp E-Series ASUP module #41153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.7
|
LGTM |
ansibot
added
shipit
ansibot
added
netapp
storage
needs_revision
ansibot
added
core_review
ansibot
removed
the
needs_revision
mattclay
reviewed
Jun 27, 2018
| @@ -1,3 +0,0 @@ | |||
| --- | |||
There was a problem hiding this comment.
Ah, that's the reason why the tests failed. I was really intending to clear out any changes we made to the file. Oops. Our local CI has an independent copy, which is why I didn't see any issues before pushing.
mattclay
added
the
ci_verified
ansibot
added
core_review
ansibot
added
the
stale_ci
ansibot
added
shipit
ASUP, or Auto-Support, is a mechanism that allows NetApp support to receive information on the status of E-Series storage-systems in order to proactively resolve issues for customers. This module gives customers the ability to tune ASUP settings to their liking, including disabling the feature entirely.
gundalow
reviewed
Aug 28, 2018
| @@ -121,24 +121,31 @@ class ModuleDocFragment(object): | |||
| api_username: | |||
| required: true | |||
| description: | |||
| - The username to authenticate with the SANtricity WebServices Proxy or embedded REST API. | |||
| - The username to authenticate with the SANtricity Web Services Proxy or Embedded Web Services API. | |||
There was a problem hiding this comment.
I think this change needs removing from this PR (as it's been done in another PR which has since been merged)
Also you need to rebase to resolve the merge conflict https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
gundalow
reviewed
Aug 28, 2018
| @@ -1138,7 +1138,6 @@ lib/ansible/modules/storage/netapp/na_cdot_volume.py E322 | |||
| lib/ansible/modules/storage/netapp/na_cdot_volume.py E324 | |||
| lib/ansible/modules/storage/netapp/na_cdot_volume.py E325 | |||
| lib/ansible/modules/storage/netapp/netapp_e_amg.py E322 | |||
| lib/ansible/modules/storage/netapp/netapp_e_amg.py E325 | |||
| lib/ansible/modules/storage/netapp/netapp_e_amg_role.py E322 | |||
There was a problem hiding this comment.
I think this change needs removing from this PR (as it's been done in another PR which has since been merged)
Also you need to rebase to resolve the merge conflict https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
gundalow
requested changes
Aug 28, 2018
| to NetApp to help better support your system. No personally identifiable information, passwords, etc, will | ||
| be collected. | ||
| default: present | ||
| choices: |
| possible that the bundle did not contain all of the required information at the time of the event. | ||
| Enabling this option allows NetApp support personnel to manually request transmission or re-transmission | ||
| of support data in order ot resolve the problem. | ||
| - Only applicable if I(state=present). |
| argument_spec = eseries_host_argument_spec() | ||
| argument_spec.update(dict( | ||
| state=dict(type='str', required=False, default='present', aliases=['asup', 'auto_support', 'autosupport'], | ||
| choices=['present', 'absent', 'enabled', 'disabled']), |
ansibot
added
needs_rebase
Added coverage and validation to asup integration and unit testing
ansibot
removed
the
needs_rebase
|
@gundalow I believe I've resolved all of the requested changes with this patch. |
|
@gundalow The requested changes have been resolved. |
gundalow
approved these changes
Aug 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ASUP, or Auto-Support, is a mechanism that allows NetApp support
to receive information on the status of E-Series storage-systems
in order to proactively resolve issues for customers. This module
gives customers the ability to tune ASUP settings to their liking,
including disabling the feature entirely.
ISSUE TYPE
COMPONENT NAME
netapp_e_asup
ANSIBLE VERSION
ADDITIONAL INFORMATION