more integration test improvements #41184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test |
ansibot
added
WIP
added 2 commits
June 6, 2018 20:49
ansibot
added
needs_ci
ansibot
added
support:certified
|
The test |
|
Could you please fill in the issue template correctly? |
ansibot
added
bug
zikalino
changed the title
ansibot
removed
the
WIP
yungezz
reviewed
Jun 8, 2018
| account_type: Standard_LRS | ||
|
|
||
| - name: Create virtual network | ||
| azure_rm_virtualnetwork: | ||
| resource_group: "{{ resource_group }}" | ||
| name: testvm001 | ||
| name: "vn{{ rpfx }}" |
| state: absent | ||
| vm_size: Standard_A0 | ||
| register: output | ||
|
|
||
| - name: Delete public ip |
There was a problem hiding this comment.
will deletion fail caused test fail?
added 2 commits
June 8, 2018 13:16
ansibot
added
needs_rebase
yungezz
approved these changes
Jun 8, 2018
added 2 commits
June 8, 2018 13:22
ansibot
removed
needs_rebase
|
@nitzmahone do you think we could merge this pr? |
ansibot
removed
the
needs_revision
|
merge this purely test fixing. |
yungezz
reviewed
Jun 12, 2018
| storage_name: "st{{ resource_group | hash('md5') | truncate(7, True, '') }}{{ 1000 | random }}" | ||
| storage_container_name: "sc{{ resource_group | hash('md5') | truncate(7, True, '') }}{{ 1000 | random }}" | ||
| public_ip_name: "pip{{ resource_group | hash('md5') | truncate(7, True, '') }}{{ 1000 | random }}" | ||
| security_group_name: "pip{{ resource_group | hash('md5') | truncate(7, True, '') }}{{ 1000 | random }}" |
There was a problem hiding this comment.
another prefix instead of 'pip'?
yungezz
reviewed
Jun 12, 2018
| storage_blob: testvm001.vhd | ||
| storage_account: "{{ storage_name }}" | ||
| storage_container: "{{ storage_container_name }}" | ||
| storage_blob: "blob.vhd" |
added 2 commits
June 12, 2018 09:56
ansibot
added
the
needs_revision
jacum
pushed a commit
to jacum/ansible
that referenced
this pull request
Jun 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixing issues related to Azure integration tests.
This PR is supposed to fix too many azure_rm_publicip resources create and not deleted by tests.
Also assigning random names to resources to avoid conflicts.
ISSUE TYPE
COMPONENT NAME
azure_rm_networkinterface
azure_rm_publicipaddress
azure_rm_image
azure_rm_managed_disk
azure_rm_loadbalancer
ANSIBLE VERSION
2.6
ADDITIONAL INFORMATION