Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vmware_host_lockdown.py #41189

Merged
merged 1 commit into from
Jun 7, 2018
Merged

Update vmware_host_lockdown.py #41189

merged 1 commit into from
Jun 7, 2018

Conversation

LastCaress77
Copy link
Contributor

SUMMARY

line 192; str should be list. Line 147 (for) expects list.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

Vmware_host_lockdown.py

ANSIBLE VERSION
2.5.2
ADDITIONAL INFORMATION
Msg: ESXi %s not found (%s only shows first character of hostname which led to bug being found)

@LastCaress77
Update vmware_host_lockdown.py
dc2d63e 
line 192; str should be list. Line 147 (for) expects list.
@ansibot
Copy link
Contributor

ansibot commented Jun 6, 2018

cc @Akasurde @dav1x @warthog9
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Jun 6, 2018
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Jun 6, 2018
@Akasurde Akasurde self-requested a review June 6, 2018 14:31
@Akasurde
Copy link
Member

Akasurde commented Jun 6, 2018

@LastCaress77 Thanks for debugging and submitting this PR.

Akasurde
Akasurde approved these changes Jun 7, 2018
View reviewed changes
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@Akasurde Akasurde merged commit a735855 into ansible:devel Jun 7, 2018
@LastCaress77 LastCaress77 deleted the patch-1 branch June 8, 2018 22:51
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@LastCaress77
Update vmware_host_lockdown.py (ansible#41189)
afb65f9 
esxi_hostname should be 'list' instead of 'str'
@ansible ansible locked and limited conversation to collaborators Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LastCaress77 @ansibot @Akasurde